Skip to content

Conversation

@Privatech38
Copy link
Contributor

@Privatech38 Privatech38 commented Dec 30, 2025

This PR adds API for stopwatches added in 1.21.11.

What worries me is that restart replaces the handle only for the instance it was called on and not other instances that reference the same handle.

@Privatech38 Privatech38 requested a review from a team as a code owner December 30, 2025 16:49
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Dec 30, 2025
@lynxplay
Copy link
Contributor

Not trying to sound rude but, what would event be a usecase for this addition.
The only remote thing I could maybe ever think of is some weird plugin<->datapack interaction but that seems very very far fetched.

Any plugin can already use google commons or apaches StopWatch to achieve the same.
This, at least right now to me, feels like exposing something just for the same of exposing it.

@Privatech38
Copy link
Contributor Author

From what I gathered it saves on server shutdown which does help in some niche cases I suppose.

I do agree there aren't many use cases and wouldn't mind if the PR is closed.

@lynxplay
Copy link
Contributor

I'll throw it at some other team members too but yea, I don't see much usecase for exposing this.
But maybe I am wrong so, lets wait on some more input 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

2 participants