Add parsing for 'Forced Outcome' oracle passive, minion presence passives, and bugfix for Inspiring Ally#1680
Add parsing for 'Forced Outcome' oracle passive, minion presence passives, and bugfix for Inspiring Ally#1680Dimencia wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
…, and fix bug with companion damage applies to self
…d of life and mana regen
|
Hold on this, the Forced Outcome calcs are wrong (using INC instead of MORE, and the skill clearly says 'less'), and I want to double check a few things as I make that change, because it seems odd that having it is worse than not having it at <25% crit chance or so |
|
You're using average number of re-rolls, which is not the correct approach. In your case, any expected value over 3.3 will give you 0% effective crit multi, which is not true. Even if you just have 5% crit chance, you'll still get 100% of your crit bonus in 5% of cases, so you know it can't be true. Afaik, you only care about the chances for different scenarios
And then you calculate the average expected crit multi from the proportions of those chances. Maybe you can join the Discord (if you haven't already) though. There were still some open questions regarding the interaction with "Bifurcated" critical hits iirc. |
|
Also @Dimencia the issues and additions you made you be spread into 4 separate PRs with the 2 companion ones being together and the other ones being on their own |
Just wanted to get those passives working so I could plan my build, but the changes are probably straightforward enough to merge in for everyone