Fix for Foulborn Choir of the Storm calculation #9421
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9410 .
Description of the problem being solved:
Foulborn Choir of the Storm along with Radiant Faith was producing incorrect values for both the % increased mana gained (in-game values round down) and for the base ES granted by Radiant Faith when the amulet is equipped.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Supplied PoB: https://pobb.in/JX6dPx2-Tt5H
With Step 2 above applied: https://pobb.in/iT5syI5O5TeM
Before screenshot:
After screenshot:
Note: I did not want to change the stat calculations and steps in
CalcPerform.luato avoid causing more bugs, but the issue is caused bydoActorLifeManaReservationbeing called more than once (once inCalcPerform.luaand afterwards inCalcDefence.lua). Only the latter call has the correct value of maximum mana and hence reserved mana/base ES granted by Radiant Faith because it accounts the increases by Foulborn Choir of the Storm by that point in the calculations.