fix: Use foreach/doSNOW for restart write.ensemble.configs to restore logger output#4018
Open
S1DDHEY wants to merge 2 commits into
Open
fix: Use foreach/doSNOW for restart write.ensemble.configs to restore logger output#4018S1DDHEY wants to merge 2 commits into
S1DDHEY wants to merge 2 commits into
Conversation
DongchenZ
approved these changes
Jun 1, 2026
infotroph
requested changes
Jun 1, 2026
Member
There was a problem hiding this comment.
Sorry to jump in after approval, but this looks to me like it will make sda.enkf.multisite stop respecting the run_parallel flag and instead use n-1 cores no matter what the user requests. @DongchenZ am I missing another place the parallel setting gets passed around?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3581
Replaces the restart-path parallel dispatch for
write.ensemble.configs()insda.enkf_MultiSite.Rfromfurrr::future_map2()toforeach+doSNOW, matching the existing non-restart code path.This fixes missing/delayed
PEcAn.loggeroutputTesting
write.ensemble.configs()is emitted by reproducing the “multi-path input with no<samplingspace>” error underforeach/doSNOW(captured viaPEcAn.logger::logger.setOutputFile()from the worker).