Merged
Conversation
The previous setup used artifact-based GitHub Pages deployment which conflicted with the PR preview action that pushes to the gh-pages branch. This change switches the main deployment to also use the gh-pages branch, making both workflows compatible. Changes: - Replace artifact-based deployment with peaceiris/actions-gh-pages action - Configure to deploy from gh-pages branch - Add keep_files: true to preserve PR preview directories - Simplify permissions to only require contents: write Note: Repository Pages settings must be configured to deploy from the gh-pages branch for this to work.
Simplified deployment by merging static.yml and pr-preview.yml into a
single pages.yml workflow. The rossjrw/pr-preview-action handles both:
- Main branch pushes → deploy to gh-pages root (production)
- Pull requests → deploy to gh-pages/pr-previews/pr-{number}
- PR close → cleanup preview directory
This reduces complexity and maintenance while providing the same
functionality. One workflow, one action, all deployments.
Changes:
- Merged pr-preview.yml and static.yml into pages.yml
- Added push trigger for main branch deployment
- Renamed jobs to 'deploy' and 'cleanup' for clarity
- Removed redundant static.yml workflow
PhilipMathieu
deleted the
claude/fix-pr-preview-deploy-01BHa8uuPpeKWwLCjzYZWwUk
branch
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.