Allow blocks to define that they are only selectable when item can be placed on it#2983
Closed
DellieDelta wants to merge 4 commits intoPixelGuys:masterfrom
Closed
Allow blocks to define that they are only selectable when item can be placed on it#2983DellieDelta wants to merge 4 commits intoPixelGuys:masterfrom
DellieDelta wants to merge 4 commits intoPixelGuys:masterfrom
Conversation
DellieDelta
force-pushed
the
remove-fluid-case-from-block-select
branch
from
9783718 to
7272d0e
Compare
…d that'll get removed later anyway
Contributor
Author
|
Closing because I don't want to add the field .placementTags that'll only be temporary anyway, and because fitting this into the existing tag system leads to other problems. Sooo this can be revisited when there's some kind of better placement constraint checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To remove the
.fluidcase in item selection, preparation for #627Adds the block field
.placementTagsand the block selectionRule.placeableIt's a simple version for now (selection happens if a placementTag overlaps with a block tag), but it can be changed in the future to some kind of condition checking. Like replacing it with
.placementConstraints(like tagOverlap, onTop, onBottom), which can work similarly to.selectionRule. To get closer to fixing #2491I'll also make it possible separately to define multiple selectionRules per block in #2987, to make both the selectionRules
.toolEffectiveand.placeablepossible on the same block, in preparation for adding buckets