ECS Party | The Bag by IntegratedQuantum · Pull Request #2989 · PixelGuys/Cubyz

IntegratedQuantum · 2026-04-27T19:28:43Z

Since it exists now, I decided to put the relevant stuff into the ECS and following the pattern: Anything remotely related to the ECS gets the ECS label and number in the title :P

Remaining work:

make an issue for the missing inventory actions (right clicking, shift clicking)
display the capacity

fixes #73

tillpp · 2026-04-27T23:28:59Z

Ahhh! i already have an ECS14 , not pushed tho

tillpp · 2026-04-27T23:34:34Z

I decided to put the relevant stuff into the ECS and following the pattern: Anything remotely related to the ECS gets the ECS label and number in the title!

HEy! all ECS parts are related to the big chunky #2652 !
A complete misunderstanding what the label stands for!

notice for example how PlayerComponent is not part of the ECS series: #2889 even though its ECS related, because it's not 2652 related!

Or PVP #2890 is also not part of the series, even though it is ECS related! because its not 2652 related!

all ECS parts are intended to be related to 2652

If you could have handled a 4k PR i would have put all ECS parts into this one PR

so name change requested!

tillpp · 2026-04-27T23:45:15Z

Also: please include screenshots when adding something visual

tillpp · 2026-04-28T00:09:38Z


 		user.spawnPos = playerData.get(?Vec3d, "playerSpawnPos", null);
+
+		if (main.entity.components.@"cubyz:bag".server.get(user.id) == null) {


could you move this into initPlayer?
to make it more consistent with the other player related components (@"cubyz:model")
or do it the other way around, having the default model loaded where the bag is loaded,

Maybe this is a pattern that will occur so often, that it would make sense to have some kind of general main.entity.server.initNewPlayer functionality.

Wunka

Just a small thing so we don't need to rewrite this later.

Wunka · 2026-04-28T06:33:27Z

+	};
+
+	const TakeFromPlayerBag = struct { // MARK: TakeFromPlayerBag
+		dest: InventoryAndSlot,


Can you maybe use here the Inventories as the destinations, with a putItemsInto.
Currently this does not change really anything but would stop us from later needing to refactor this if needed.
I also thought maybe we want shift clicking in general to have the hand as a fallback?

Wunka · 2026-04-28T07:35:05Z

+
+	const topItem = self.inventory.peek(0);
+	const shouldRenderStackSizeText = topItem.item.stackSize() > 1;
+	if (shouldRenderStackSizeText) {


from here a lot is just copy from itemslot. I know they have key differences but maybe we want to generlize something here? Like a itemStackInformation we can render on top?

I decided to move part of the rendering code to items.zig

IntegratedQuantum · 2026-04-28T18:16:14Z

A complete misunderstanding what the label stands for!

Oh sorry, I renamed it to avoid the name conflicts :P

IntegratedQuantum · 2026-04-28T18:17:24Z

Also: please include screenshots when adding something visual

https://discord.com/channels/443805812390100992/574185221939789855/1498398538424651817

tillpp · 2026-04-28T18:42:43Z

Also: please include screenshots when adding something visual

In the PR!!!

Oh sorry, I renamed it to avoid the name conflicts :P

what does this have to do with a Party?

Wunka · 2026-04-28T19:18:46Z

+			var remainingAmount = @min(self.amount, bag.peek(0).amount);
+			const item = bag.peek(0).item;
+			outer: for (self.destinations.inventories) |inv| {
+				for (inv._items, 0..) |itemStack, slot| {
+					if (remainingAmount == 0) break :outer;
+					if (itemStack.item != .null and !std.meta.eql(itemStack.item, item)) continue;
+
+					const amount = @min(remainingAmount, item.stackSize() - itemStack.amount);
+					remainingAmount -= amount;
+
+					ctx.execute(.{.takeFromBag = .{.source = bag, .dest = .{.inv = inv, .slot = @intCast(slot)}, .amount = amount}});
+				}
+			}


why did you not just use the putItemsInto? you would just need to expand the Provider (in a fast done not complete tested version) this is how the Provider would look like:

const Provider = union(enum) { move: InventoryAndSlot, create: Item, fromBag: *BagInventory, pub fn getBaseOperation(provider: Provider, dest: InventoryAndSlot, amount: u16) sync.Command.BaseOperation { return switch (provider) { .move => |slot| .{.move = .{ .dest = dest, .amount = amount, .source = slot, }}, .create => |item| .{.create = .{ .dest = dest, .amount = amount, .item = item, }}, .fromBag => |bag| .{.takeFromBag = .{ .dest = dest, .source = bag, .amount = amount, }}, }; } pub fn getItem(provider: Provider) Item { return switch (provider) { .move => |slot| slot.ref().item, .create => |item| item, .fromBag => |bag| bag.peek(0).item, }; } };

maybe I am not seeing a different problem?

In my current code I stop depositing when the item changes.

ah, ok. yeah makes sense

IntegratedQuantum · 2026-04-28T19:24:55Z

what does this have to do with a Party?

It's a birthday party for the ECS: The first actual ECS feature that lands :P

tillpp · 2026-04-28T19:31:44Z

It's a birthday party for the ECS: The first actual ECS feature that lands :P

NOOOO!
you are the Evil Snale
YOu always have been!

Wunka · 2026-04-28T19:47:32Z

when dragging over the bag you take from it but also put things into the selected itemslots

2026-04-28.21-41-57.mp4

this is I think a more simple example to the general problem. It seems the taking is done on release even if you are not hovering over the bag anymore

2026-04-28.21-46-00.mp4

Wunka · 2026-04-28T20:31:55Z

Another thing I noted. When having for example a ~~tool~~ procedural item at the top, there is no tooltip.

IntegratedQuantum · 2026-04-29T05:23:36Z

Tooltip is blocked by #2527

Wunka · 2026-04-29T09:28:40Z

+				for (inv._items, 0..) |itemStack, slot| {
+					if (remainingAmount == 0) break :outer;
+					if (itemStack.item != .null and !std.meta.eql(itemStack.item, item)) continue;
+					if (!std.meta.eql(bag.peek(0).item, item)) continue;


could you not break here? this will never change after it once becomes true

Wunka · 2026-04-29T09:33:58Z

+			outer: for (self.destinations.inventories) |inv| {
+				for (inv._items, 0..) |itemStack, slot| {
+					if (remainingAmount == 0) break :outer;
+					if (itemStack.item != .null and !std.meta.eql(itemStack.item, item)) continue;
+					if (!std.meta.eql(bag.peek(0).item, item)) continue;
+
+					const amount = @min(remainingAmount, item.stackSize() - itemStack.amount);
+					remainingAmount -= amount;
+
+					ctx.execute(.{.takeFromBag = .{.source = bag, .dest = .{.inv = inv, .slot = @intCast(slot)}, .amount = amount}});


in general this does not match the behavior we want for inventory -> inventories.
I would still suggest to just use putItemsInto and add there the if(!std.meta.eql(provider.getItem(), item)) break behavior

I decided to instead precalculate the amount here.

ikabod-kee · 2026-04-29T15:13:20Z

Wait, so the bag can hold 120 STACKS of items???

Wunka · 2026-04-29T15:21:44Z

+				amount +|= stack.amount;
+			}
+			amount = @min(amount, self.amount);
+			std.debug.assert(self.destinations.putItemsInto(ctx, amount, .{.bag = bag}) == 0);


this would mean, you crash the game if the amount doesn't fit into the destinations. I would say just ignore the return value

Oh right, I wasn't thinking

Wunka

I really like it!
The most that the amount which is shown is stack independent and instead item driven

Since it exists now, I decided to put the relevant stuff into the ECS and following the pattern: Anything remotely related to the ECS gets the ECS label and number in the title :P <img width="2560" height="1413" alt="Screenshot at 2026-04-28 21-19-39" src="https://github.com/user-attachments/assets/3f176c86-9408-4c3f-b49d-791be39c83a4" /> Remaining work: - [x] make an issue for the missing inventory actions (right clicking, shift clicking) - [x] display the capacity fixes PixelGuys#73

IntegratedQuantum added 4 commits April 27, 2026 21:21

Add the BagInventory as a new structure

997a26a

Add the bag component, and add it to all players by default

4b1c92d

Add sync commands for adding and removing items from/to the bag

501be65

Add the BagSlot gui component

5f95ee2

IntegratedQuantum requested a review from tillpp April 27, 2026 19:28

tillpp suggested changes Apr 28, 2026

View reviewed changes

Wunka suggested changes Apr 28, 2026

View reviewed changes

Wunka reviewed Apr 28, 2026

View reviewed changes

IntegratedQuantum changed the title ~~ECS Part 14 | The Bag~~ ECS Party | The Bag Apr 28, 2026

IntegratedQuantum added 3 commits April 28, 2026 20:24

Add the bag in initPlayer

3923e0f

Fix double free

c54fa7d

Use Inventories for takeFromBag

53941db

IntegratedQuantum added 3 commits April 28, 2026 20:50

Display the cumulative count of the topmost item

8410e3c

fixes

981cf90

Move common item render code to items.zig

259b5d5

IntegratedQuantum requested review from Wunka and tillpp April 28, 2026 19:13

Wunka suggested changes Apr 28, 2026

View reviewed changes

IntegratedQuantum added 2 commits April 28, 2026 21:21

Set limit to 120

1e7fe77

Add a count of slots used

fb1999c

Only interact with the bag if you are still hovering it

3225c9b

IntegratedQuantum requested a review from Wunka April 29, 2026 05:27

Wunka suggested changes Apr 29, 2026

View reviewed changes

Use putItemsInto

046e2e6

IntegratedQuantum requested a review from Wunka April 29, 2026 15:17

Wunka suggested changes Apr 29, 2026

View reviewed changes

Ignore incomplete transfers

e8bae37

IntegratedQuantum requested a review from Wunka April 29, 2026 15:22

Wunka approved these changes Apr 29, 2026

View reviewed changes

tillpp suggested changes Apr 30, 2026

View reviewed changes

Comment thread src/entityComponent/bag.zig

This was referenced Apr 30, 2026

More inventory actions (right clicking, shift clicking) for the bag #2997

Open

Improve the bag UI #2998

Open

IntegratedQuantum merged commit 94fee0a into PixelGuys:master Apr 30, 2026
1 check passed


		user.spawnPos = playerData.get(?Vec3d, "playerSpawnPos", null);

		if (main.entity.components.@"cubyz:bag".server.get(user.id) == null) {

Uh oh!

Conversation

IntegratedQuantum commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tillpp commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tillpp commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tillpp commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Wunka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Wunka Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IntegratedQuantum commented Apr 28, 2026

Uh oh!

IntegratedQuantum commented Apr 28, 2026

Uh oh!

tillpp commented Apr 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IntegratedQuantum commented Apr 28, 2026

Uh oh!

tillpp commented Apr 28, 2026

Uh oh!

Wunka commented Apr 28, 2026

Uh oh!

Wunka commented Apr 28, 2026

Uh oh!

IntegratedQuantum commented Apr 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Wunka Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ikabod-kee commented Apr 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Wunka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

IntegratedQuantum commented Apr 27, 2026 •

edited

Loading

tillpp commented Apr 27, 2026 •

edited

Loading

tillpp commented Apr 27, 2026 •

edited

Loading

tillpp commented Apr 27, 2026 •

edited

Loading

Wunka left a comment •

edited

Loading

Wunka Apr 28, 2026 •

edited

Loading

Wunka Apr 29, 2026 •

edited

Loading