Skip to content

Add extra checks for lucky egg navigation. #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mysticial merged 1 commit into from
May 26, 2026
Merged

Add extra checks for lucky egg navigation. #1268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 49 additions & 6 deletions SerialPrograms/Source/PokemonFRLG/Programs/Farming/PokemonFRLG_LuckyEggFarmer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include "PokemonFRLG/Inference/Dialogs/PokemonFRLG_DialogDetector.h"
#include "PokemonFRLG/Inference/Dialogs/PokemonFRLG_BattleDialogs.h"
#include "PokemonFRLG/Inference/Menus/PokemonFRLG_PartyHeldItemDetector.h"
#include "PokemonFRLG/Inference/Menus/PokemonFRLG_StartMenuDetector.h"
#include "PokemonFRLG/Inference/PokemonFRLG_BattleSelectionArrowDetector.h"
#include "PokemonFRLG/Inference/PokemonFRLG_PokedexRegisteredDetector.h"
#include "PokemonFRLG/Inference/PokemonFRLG_WildEncounterReader.h"
Expand Down Expand Up @@ -128,7 +129,7 @@ bool LuckyEggFarmer::navigate_to_chansey(ConsoleHandle& console, ProControllerCo
pbf_press_dpad(context, DPAD_UP, 100ms, 0ms);
pbf_press_dpad(context, DPAD_RIGHT, 1966ms, 0ms);
pbf_press_dpad(context, DPAD_UP, 1800ms, 0ms);
pbf_press_dpad(context, DPAD_RIGHT, 450ms, 0ms);
pbf_press_dpad(context, DPAD_RIGHT, 600ms, 0ms);
pbf_wait(context, 1000ms);
},
{ zone_exit }
Expand All @@ -150,8 +151,29 @@ bool LuckyEggFarmer::navigate_to_chansey(ConsoleHandle& console, ProControllerCo
);

if (ret != 0){
console.log("Failed to detect overworld after first zone transition.");
return false;
pbf_wait(context, 1000ms);
context.wait_for_all_requests();

console.log("Failed to detect overworld after first zone transition. Attempting to open Start menu as a secondary check.");
StartMenuWatcher start_menu(COLOR_RED);

context.wait_for_all_requests();
ret = run_until<ProControllerContext>(
console, context,
[](ProControllerContext& context){
pbf_press_button(context, BUTTON_PLUS, 200ms, 1800ms);
},
{ start_menu }
);

if (ret != 0){
console.log("Failed to open Start menu.");
context.wait_for_all_requests();
pbf_mash_button(context, BUTTON_B, 1000ms);
return false;
}

pbf_mash_button(context, BUTTON_B, 1000ms);
}

console.log("Exiting first zone...");
Expand All @@ -177,7 +199,7 @@ bool LuckyEggFarmer::navigate_to_chansey(ConsoleHandle& console, ProControllerCo
pbf_press_dpad(context, DPAD_UP, 675ms, 0ms);
pbf_press_dpad(context, DPAD_LEFT, 2000ms, 0ms);
pbf_press_dpad(context, DPAD_DOWN, 130ms, 0ms);
pbf_press_dpad(context, DPAD_LEFT, 3000ms, 0ms);
pbf_press_dpad(context, DPAD_LEFT, 3300ms, 0ms);
},
{ zone_exit }
);
Expand All @@ -196,8 +218,29 @@ bool LuckyEggFarmer::navigate_to_chansey(ConsoleHandle& console, ProControllerCo
);

if (ret != 0){
console.log("Failed to detect overworld after second zone transition.");
return false;
pbf_wait(context, 1000ms);
context.wait_for_all_requests();

console.log("Failed to detect overworld after second zone transition. Attempting to open Start menu as a secondary check.");
StartMenuWatcher start_menu(COLOR_RED);

context.wait_for_all_requests();
ret = run_until<ProControllerContext>(
console, context,
[](ProControllerContext& context){
pbf_press_button(context, BUTTON_PLUS, 200ms, 1800ms);
},
{ start_menu }
);

if (ret != 0){
console.log("Failed to open Start menu.");
context.wait_for_all_requests();
pbf_mash_button(context, BUTTON_B, 1000ms);
return false;
}

pbf_mash_button(context, BUTTON_B, 1000ms);
}

console.log("Exiting second zone...");
Expand Down
Loading