Updated Helioptile hunter

[Developer-Butters]

Updated the helioptile shiny hunter to use fast travel and day/night state detection to improve the function of the program.

Added ButtonBInterior to button detector and used that as an improvement to the mapdetector.

Tested Helioptile, Donut Maker, and Mega Shard Farmer to confirm that the updates to MapDetector did not cause harm.

[Mysticial]

Tests are failing on the button detectors.

[Mysticial]

Why do you need to make a separate detector for the interior? It looks like we already have that here:

Arduino-Source/SerialPrograms/Source/PokemonLZA/Inference/PokemonLZA_ButtonDetector.cpp

Line 220 in ce58377

if (match_button_black_interior(m_button_type)){

Can you try to debug why that one isn't working?

[Developer-Butters]

Why do you need to make a separate detector for the interior? It looks like we already have that here:

Arduino-Source/SerialPrograms/Source/PokemonLZA/Inference/PokemonLZA_ButtonDetector.cpp

Line 220 in ce58377

if (match_button_black_interior(m_button_type)){

Can you try to debug why that one isn't working?

[Developer-Butters]

I got the tests to run locally and ran a debug for the detector. it is failing because it's not detecting the interior B in the hyperspace png. Would a "if interior returns false, check for the B button instead, and if both return false, return false" be ok? alternatively I can try detecting the right stick symbol at the top right or the travel spots icon as a 3rd point of confirmation for map open.

[Developer-Butters]

Converted to draft while I wait for confirmation of packages update and while I finalize code cleanup of mistakes I made

[Developer-Butters]

All tests passed now. The new detector sees the fly spot icon and helioptile hunter now uses fast travel movement instead of blind timing based joystick commands to travel from place to place. I've also made the program indifferent to where or what time of day the player starts the program.

[Mysticial]

I just rebased and did a slight refactor of the MapDetector changes. So that part is good to go. But the Helioptile program is failing to detect this as sunny.

Can you pull out the just the MapDetector changes into separate PR so that can be merged first?

[Developer-Butters]

I just rebased and did a slight refactor of the MapDetector changes. So that part is good to go. But the Helioptile program is failing to detect this as sunny.

Can you pull out the just the MapDetector changes into separate PR so that can be merged first?

I'll do that and see what I can do for the screenshot provided. I didn't encounter this during my testing in game.

[Developer-Butters]

Can you pull out the just the MapDetector changes into separate PR so that can be merged first?

Marked as draft because I don't really know how to to quickly do the split you're requesting. I'll research how best to do it in the coming days and make the necessary changes.

[Developer-Butters]

I just rebased and did a slight refactor of the MapDetector changes. So that part is good to go. But the Helioptile program is failing to detect this as sunny.

Can you pull out the just the MapDetector changes into separate PR so that can be merged first?

Marked as ready for review. I still have not been able to replicate this issue, so I would need more information to do any additional testing or changes. I tested both my change to helioptile hunter and the weather finder program which both rely on the same weather detector functions.

For the weather finder program, I looked for both clear and sunny weather. encountered no issue.

For the hunter, I first changed the code to test only day and clear weather, no issues, and the program warped to wild zone 14 when appropriate. I then looked for only sunny and again the program warped to WZ 14 with no issues when appropriate.

I tested on every capture card and switch I own (switch v1, v2, oled, and switch 2).

[jw098]

Does the Sun detector work on the screenshot above?

[Developer-Butters]

Does the Sun detector work on the screenshot above?

I'm not sure how to test just a screenshot. I had GPT help me create something that runs the weather detector on its own, and that suggests that weather detector doesn't work on the screenshot. Of course that's inconclusive IMO since it's the product of AI and the program finds the sunny weather on the real game.

Here's an example of weather finder working just fine to find sunny weather.

I tried running the weather finder program on the screenshot, but it also failed to detect that it was a screenshot of the map, so it may be that I the screenshot doesn't save properly for me too. The only way I was able to save kuro's nshot wwas by clicking on it on my phone and downloading it that way. On a browser I get this

[Developer-Butters]

I tried my test program on the live game where I found the sunny weather and it does detect sunny. Score one for AI I suppose. so that narrows it down to something local to Kuro or my inability to get the screenshot properly.

[Developer-Butters]

I'm preparing a refactor of the weather detector using waterfill instead of cropped template matching. It will need new resources to operate effectively so I will upload those first.