Skip to content

Fix staged deploy fallback for simulation gateway URL#3504

Merged
anth-volk merged 2 commits intomasterfrom
fix/sim-gateway-auth-client-2
Apr 24, 2026
Merged

Fix staged deploy fallback for simulation gateway URL#3504
anth-volk merged 2 commits intomasterfrom
fix/sim-gateway-auth-client-2

Conversation

@anth-volk
Copy link
Copy Markdown
Collaborator

Summary

  • rebase the staged auth client branch onto current origin/master
  • default staged App Engine deploys to the stable simulation gateway URL when SIMULATION_API_URL is unset or blank
  • stop treating SIMULATION_API_URL as required deploy-time configuration while preserving environment overrides
  • add coverage for the blank-env fallback in the simulation gateway client

Validation

  • uv run ruff check policyengine_api/libs/simulation_api_modal.py gcp/export.py tests/unit/libs/test_simulation_api_modal.py
  • uv run pytest --noconftest tests/unit/libs/test_simulation_api_modal.py
  • bash -n .github/scripts/validate_app_engine_deploy_env.sh

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.00%. Comparing base (01d5bc1) to head (08ba60c).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3504   +/-   ##
=======================================
  Coverage   77.00%   77.00%           
=======================================
  Files          63       63           
  Lines        3418     3418           
  Branches      617      617           
=======================================
  Hits         2632     2632           
  Misses        612      612           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk anth-volk merged commit 17b0c47 into master Apr 24, 2026
7 checks passed
@anth-volk anth-volk deleted the fix/sim-gateway-auth-client-2 branch April 24, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant