Align changelog PR check with push versioning#3505
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3505 +/- ##
=======================================
Coverage 77.00% 77.00%
=======================================
Files 63 63
Lines 3418 3418
Branches 617 617
=======================================
Hits 2632 2632
Misses 612 612
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR changelog gate was using
towncrier check --compare-with origin/master, which allowed PRs with no new fragment to pass in some branch histories while the push workflow still failed atbump_version.pywithNo changelog fragments found.This switches the PR check to the same effective contract the push workflow enforces: a PR must contain at least one real fragment file in
changelog.d/.Changes
towncrier check --compare-with origin/masterPR gate with a direct fragment-presence check.gitkeepexcludedValidation
changelog.d/uv run python .github/bump_version.pyto confirm the fragment is consumable by the push-time versioning script