Fix np.is_in typo in cps.marriage_tax_reforms (#257)#1637
Merged
Conversation
`np.is_in` is not a numpy function — the correct name is `np.isin`. Both call sites sit inside `if child_education_levels is not None:` branches, so the typo only surfaces when the reform is instantiated with that argument. Replace with `np.isin` so the reform doesn't crash with AttributeError when exercised. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MaxGhenis
approved these changes
Apr 20, 2026
Collaborator
MaxGhenis
left a comment
MaxGhenis
left a comment
There was a problem hiding this comment.
np.is_in -> np.isin. Trivial and correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
np.is_in(...)withnp.isin(...)inpolicyengine_uk/reforms/cps/marriage_tax_reforms.pylines 22 and 113.np.is_in(with underscore) does not exist in numpy. Both call sites sit insideif child_education_levels is not None:branches, so the typo only triggers when the reform is instantiated with that argument — at which point it raisesAttributeError.Found while auditing #257.
Test plan
python -c "from policyengine_uk.reforms.cps.marriage_tax_reforms import *"make formatclean🤖 Generated with Claude Code