fix: Add type annotations to prompt properties#116
Open
roh26it wants to merge 4 commits intotemp/adminfrom
Open
fix: Add type annotations to prompt properties#116roh26it wants to merge 4 commits intotemp/adminfrom
roh26it wants to merge 4 commits intotemp/adminfrom
Conversation
Added additionalProperties: true to: - parameters (object) - template_metadata (object) - prompt_metadata (object) - tool_choice (object) - functions[].items (object) - tools[].items (object) This fixes Stainless error about undefined types resulting in raw JSON fields.
…rties - config: Add additionalProperties to 'config' object in POST /configs - integration: Add CreateIntegrationResponse schema and reference it - integration: Add additionalProperties to vertex_service_account_json Fixes Stainless errors about undefined types resulting in raw JSON fields.
- POST /configs: Changed from {success, data: {id, version_id}} wrapper
to flat {id, version_id, slug, object}
- GET /configs/{slug}: Changed from {success, data: {config: ...}} wrapper
to flat object with all config fields
- PUT /configs/{slug}: Changed from {success, data: {version_id}} wrapper
to flat {version_id, object}
The actual API returns flat objects, not wrapped responses.
The API expects 'config' as an object in POST/PUT requests, not as a JSON-encoded string. Fixed the schema to use type: object with additionalProperties: true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
additionalProperties: trueto prompt-related properties to fix Stainless code generation errors.Changes
Added type annotations to:
parameters(object)template_metadata(object)prompt_metadata(object)tool_choice(object)functions[].items(object)tools[].items(object)Fixes
Resolves Stainless error: