fix(agent): redact MCP credentials from session logs - #4046
Merged
trunk-io[bot] merged 1 commit intoJul 31, 2026
Conversation
Generated-By: PostHog Code Task-Id: 7ec72017-19cb-4e77-aef0-ec6cd850eaa2
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
added
the
Stamphog
tatoalo
marked this pull request as ready for review
July 31, 2026 13:16
Contributor
|
Reviews (1): Last reviewed commit: "fix(agent): redact MCP credentials from ..." | Re-trigger Greptile |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Small, well-tested fix that redacts Authorization header values before session logs are persisted — it reduces credential exposure rather than introducing risk, doesn't touch auth flows/data models/APIs, and has a positive Greptile review signal (👍 reaction, no concerns raised) on the current head.
- Author wrote 0% of the modified lines and has 107 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 29L, 1F substantive, 68L/2F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (68L, 2F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 1fac094 · reviewed head e77dad8 |
tatoalo
enabled auto-merge (squash)
July 31, 2026 13:23
jonathanlab
approved these changes
Jul 31, 2026
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MCP configuration can include authorization credentials. Protocol messages containing that configuration are persisted in task session logs, where the credentials are unnecessary