fix(pi): focus composer when clicking chat thread - #4049
Merged
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(pi): focus composer when clicking ch..." | Re-trigger Greptile |
jonathanlab
force-pushed
the
fix/pi-thread-focus-chat
branch
from
July 31, 2026 15:18
a95c3ad to
42c63f4
Compare
There was a problem hiding this comment.
Small, contained frontend fix that extracts and reuses an existing click-guard helper for composer focus, matches its description exactly, includes new tests, and touches no risky territory.
- Author wrote 100% of the modified lines and has 10 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 49L, 3F substantive, 102L/4F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1c-medium (102L, 4F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 0ed50b9 · reviewed head 42c63f4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking a Pi chat thread did not focus its composer, unlike ACP threads.
Changes
How did you test this?
pnpm exec biome check packages/ui/src/features/pi-sessions/PiSessionView.tsx packages/ui/src/features/sessions/components/SessionView.tsx packages/ui/src/features/sessions/components/focusComposerOnPaneClick.ts packages/ui/src/features/sessions/components/focusComposerOnPaneClick.test.tspnpm --filter @posthog/ui exec vitest run src/features/sessions/components/focusComposerOnPaneClick.test.tspnpm --filter @posthog/ui typecheckAutomatic notifications