fix: enable next/image optimization in ProfileCard (#2546) - #3265
Open
aaniya22 wants to merge 2 commits into
Open
fix: enable next/image optimization in ProfileCard (#2546)#3265aaniya22 wants to merge 2 commits into
aaniya22 wants to merge 2 commits into
Conversation
…der#2546) Removed unoptimized flag and allowlisted images.unsplash.com in remotePatterns and CSP img-src for the fallback avatar. Signed-off-by: aaniya22 <aaniyaatomar@gmail.com>
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the
unoptimizedflag fromProfileCard's avatar<Image>so Next.js can actually optimize it, and allowlistedimages.unsplash.com(the fallback avatar source) innext.config.mjsfor both imageremotePatternsand the CSPimg-srcdirective.Closes #2546
Type of Change
What Changed
unoptimizedprop from the<Image>component insrc/components/ProfileCard.tsximages.unsplash.comtoimages.remotePatternsinnext.config.mjshttps://images.unsplash.comto the CSPimg-srcdirective innext.config.mjsHow to Test
ProfileCardwithout passing anavatarUrlprop (so it falls back to the Unsplash placeholder)/_next/imagerather than the raw Unsplash URLnpx vitest run test/components/ProfileCard.test.tsxExpected result: Avatar renders correctly, image requests are optimized via Next.js image pipeline, no CSP violations in console, all 4 existing tests pass.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
N/A — no UI/markup change, only image optimization behavior.
Additional Context
None.