fix: enforce react-hooks/exhaustive-deps as an error (#2562) - #3268
Merged
Priyanshu-byte-coder merged 2 commits intoJul 29, 2026
Merged
Conversation
…coder#2562) Previously a warning (or unset, inheriting default), missing hook dependencies could silently ship to production. No existing violations found in src/. Signed-off-by: aaniya22 <aaniyaatomar@gmail.com>
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Priyanshu-byte-coder
merged commit Jul 29, 2026
3e1c820
into
Priyanshu-byte-coder:main
16 of 17 checks passed
|
🎉 Merged! Thanks for contributing to DevTrack. If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers. Keep an eye on open issues for your next contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed
react-hooks/exhaustive-depsfrom a warning to an error ineslint.config.mjsso missing hook dependencies fail CI/lint instead of silently passing, preventing stale-closure bugs from shipping to production.Closes #2562
Type of Change
What Changed
"react-hooks/exhaustive-deps": "error"rule override ineslint.config.mjsHow to Test
npx eslint src— should pass cleanly on current codebase (no existing violations)useEffectwith a missing dependency anywhere insrc/and re-run lintExpected result: Missing hook dependencies are reported as lint errors, not warnings.
Screenshots / Recordings
N/A — lint config change, no UI impact.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
N/A — no UI/markup change.
Additional Context
Verified no existing violations in
src/before merging this in, so this shouldn't break current CI — only future PRs with genuinely missing hook dependencies.