Add imports for namespaced Html and Title classes #91
Conversation
📝 WalkthroughWalkthroughThe changes update MediaWiki and PHP version requirements in documentation and configuration files, adjust import statements for the Changes
Estimated code review effort1 (~7 minutes) 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
20-35: Consider adding a job that exercises the lowest supported PHP/MW combo.The matrix now starts with
REL1_40on PHP 8.0.
Because the README still promises support for PHP 7.4, CI no longer protects that floor.
Adding one entry such as- mw: 'REL1_40' php: 7.4 experimental: falsewould ensure you don’t accidentally introduce 8.x-only syntax.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/ci.yml(3 hunks)README.md(1 hunks)extension.json(1 hunks)src/EntryPoints/NetworkFunction.php(1 hunks)src/EntryPoints/SpecialNetwork.php(1 hunks)src/NetworkFunction/AbstractNetworkPresenter.php(1 hunks)
🔇 Additional comments (4)
src/EntryPoints/NetworkFunction.php (1)
12-12: LGTM: Correct namespace import update for Title class.The import statement correctly updates from the global
Titleclass to the namespacedMediaWiki\Title\Title, which aligns with MediaWiki's namespace migration for version 1.44 compatibility.src/NetworkFunction/AbstractNetworkPresenter.php (1)
7-7: LGTM: Correct namespace import update for Html class.The import statement correctly updates from the global
Htmlclass to the namespacedMediaWiki\Html\Html, maintaining compatibility with MediaWiki 1.44 requirements.src/EntryPoints/SpecialNetwork.php (1)
13-13: LGTM: Correct namespace import updates for Html and Title classes.Both import statements correctly update from global classes to their namespaced MediaWiki equivalents:
Html→MediaWiki\Html\HtmlTitle→MediaWiki\Title\TitleThese changes maintain compatibility with MediaWiki 1.44 requirements while preserving existing functionality.
Also applies to: 15-15
extension.json (1)
19-21: Version bump looks correct; please cross-check other metadata.The minimum
MediaWikirequirement is now>= 1.40.0, which matches the PR intent.
Double-check that:
- Any
composer.json(if present) also lists the same constraint.- All user-facing docs (README, release notes) are updated consistently.
If those are already aligned, no further action needed.
|
We need to raise the version to 4.x as per semver, due to dropping MW version support. Worth going to MW 43 right away, and then we can also fix the Title class failure for MW master |
Fixes compatibility with MW 1.44. Raise MW requirement to 1.43. Run CI on 1.44. Bump version to 4.0.0.
Use runOutputPipeline instead (available since 1.43), as getText is being removed in MW 1.45. Also use namespaced imports for ParserOptions and User.
|
Done. The second commit should also fix the tests on master/1.45. |
MediaWiki 1.43 requires PHP 8.1.0.
3 participants
Fixes compatibility with MW 1.44.
Raise MW requirement to 1.40 accordingly.
Summary by CodeRabbit