Consolidating Version Bumps #8681
Conversation
📝 WalkthroughWalkthroughThe PR updates GitHub Actions versions across nine workflow files (.github/workflows/*). Changes: actions/checkout@v4→@v6 (blossom-ci), actions/cache@v4→@v5 (cron-ngc-bundle, integration, pythonapp-min, setupapp, weekly-preview), actions/upload-artifact@v5→@v6 (docker, release), and slash-command-dispatch v5.0.0→v5.0.2 (chatops). No control-flow or other logic changes were made. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ply.github.com> I, Eric Kerfoot <[email protected]>, hereby add my Signed-off-by to this commit: c763360 Signed-off-by: Eric Kerfoot <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (10)
.github/workflows/blossom-ci.yml.github/workflows/chatops.yml.github/workflows/cron-ngc-bundle.yml.github/workflows/docker.yml.github/workflows/integration.yml.github/workflows/pythonapp-min.yml.github/workflows/pythonapp.yml.github/workflows/release.yml.github/workflows/setupapp.yml.github/workflows/weekly-preview.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: min-dep-pytorch (2.5.1)
- GitHub Check: min-dep-pytorch (2.8.0)
- GitHub Check: min-dep-os (windows-latest)
- GitHub Check: min-dep-py3 (3.10)
- GitHub Check: min-dep-py3 (3.12)
- GitHub Check: min-dep-py3 (3.9)
- GitHub Check: min-dep-py3 (3.11)
- GitHub Check: min-dep-pytorch (2.7.1)
- GitHub Check: min-dep-os (macOS-latest)
- GitHub Check: min-dep-os (ubuntu-latest)
- GitHub Check: min-dep-pytorch (2.6.0)
- GitHub Check: flake8-py3 (mypy)
- GitHub Check: flake8-py3 (codeformat)
- GitHub Check: quick-py3 (macOS-latest)
- GitHub Check: quick-py3 (windows-latest)
- GitHub Check: packaging
- GitHub Check: build-docs
- GitHub Check: flake8-py3 (pytype)
- GitHub Check: quick-py3 (ubuntu-latest)
🔇 Additional comments (7)
.github/workflows/docker.yml (1)
40-40: actions/upload-artifact@v6 is compatible. v6 has no breaking changes to artifact upload syntax. It requires Node.js 24 and GitHub Actions Runner >= 2.327.1 for self-hosted runners—typical in modern setups..github/workflows/chatops.yml (1)
13-13: Upgrade is safe. v5.0.2 contains only a bug fix for workflow discovery pagination—no breaking changes..github/workflows/integration.yml (1)
25-25: actions/cache@v5 is compatible. v5 introduces no breaking changes to cache paths or key syntax. Requires Node.js 24 and Actions Runner 2.327.1 minimum; GitHub-hosted runners meet these requirements automatically.Also applies to: 101-101
.github/workflows/pythonapp.yml (1)
41-41: LGTM. Same verification applies.Cache v5 upgrade consistent across workflows. See verification request in setupapp.yml.
Also applies to: 89-89, 144-144, 226-226
.github/workflows/pythonapp-min.yml (1)
49-49: LGTM.Consistent cache v5 upgrade.
Also applies to: 99-99, 148-148
.github/workflows/blossom-ci.yml (1)
54-54: LGTM.Checkout v6 already used in other workflows. Low risk.
.github/workflows/setupapp.yml (1)
38-38: LGTM. actions/cache@v5 upgrade is compatible.All three instances (lines 38, 98, 139) use dynamic weekly timestamp cache keys with standard paths, requiring no configuration changes. The v5 backend migration to cache service v2 APIs is infrastructure-level; no breaking changes affect the workflow file. Ensure runners meet minimum version 2.327.1.
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
.github/workflows/docker.yml (1)
60-60: Runner version requirement already flagged.Past review comment on this line correctly notes the runner version requirement. Since these jobs are currently disabled (
if: ${{ false }}), ensure runner compatibility before re-enabling.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (2)
.github/workflows/docker.yml.github/workflows/release.yml
🔇 Additional comments (3)
.github/workflows/release.yml (3)
69-69: Version alignment resolved.Upload now matches download-artifact@v7 (line 130), fixing the incompatibility flagged in past reviews. Runner 2.327.1+ requirement noted in previous comments still applies.
112-112: Version bump consistent.Aligns with upload-artifact@v7 at line 69. No issues detected.
130-130: Past comment covers this adequately.Version alignment now correct. Runner version requirement already documented in previous review.
…load-artifact v6 Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Yun Liu <[email protected]>
|
/build |
|
/build |
### Description This consolidates the version bumps from Project-MONAI#8675, Project-MONAI#8676, Project-MONAI#8677, Project-MONAI#8678, and Project-MONAI#8679 into one PR for faster CICD and review. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Eric Kerfoot <[email protected]> Signed-off-by: Yun Liu <[email protected]> Co-authored-by: Yun Liu <[email protected]> Signed-off-by: jirka <[email protected]>
2 participants
Description
This consolidates the version bumps from #8675, #8676, #8677, #8678, and #8679 into one PR for faster CICD and review.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.