(fix): USE_POOLING=false path fixes and 2-tier toggle rename#24
Merged
(fix): USE_POOLING=false path fixes and 2-tier toggle rename#24
USE_POOLING=false path fixes and 2-tier toggle rename#24Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix bugs in the
USE_POOLING=falsecode path and clarify the 2-tier pooling toggle naming.Changes
Bug fixes
DisabledPool <: AbstractArrayPool— fixes type checks failing underUSE_POOLING=falsereshape!fallback forDisabledPool{:cuda}@maybe_with_pool :backendfunction form ignoringMAYBE_POOLING_ENABLED[]Refactor: 2-tier pooling toggle rename
USE_POOLING→STATIC_POOLING(compile-time const, master switch)MAYBE_POOLING_ENABLED→MAYBE_POOLING(runtimeRef{Bool},@maybe_with_poolonly)constaliases for backward compatibilityLocalPreferences.tomlkeyuse_poolingunchangedTests
USE_POOLING=falseseparate-process tests (290+ lines)@maybe_with_pool :backendmacro expansion testsDisabledPooltestsBreaking changes
None — existing code using
USE_POOLINGandMAYBE_POOLING_ENABLEDcontinues to work.