Skip to content

(fix): USE_POOLING=false path fixes and 2-tier toggle rename#24

Merged
mgyoo86 merged 7 commits intomasterfrom
fix/USE_POOLING=false
Mar 7, 2026
Merged

(fix): USE_POOLING=false path fixes and 2-tier toggle rename#24
mgyoo86 merged 7 commits intomasterfrom
fix/USE_POOLING=false

Conversation

@mgyoo86
Copy link
Member

@mgyoo86 mgyoo86 commented Mar 7, 2026

Summary

Fix bugs in the USE_POOLING=false code path and clarify the 2-tier pooling toggle naming.

Changes

Bug fixes

  • Make DisabledPool <: AbstractArrayPool — fixes type checks failing under USE_POOLING=false
  • Add missing reshape! fallback for DisabledPool{:cuda}
  • Fix @maybe_with_pool :backend function form ignoring MAYBE_POOLING_ENABLED[]

Refactor: 2-tier pooling toggle rename

  • USE_POOLINGSTATIC_POOLING (compile-time const, master switch)
  • MAYBE_POOLING_ENABLEDMAYBE_POOLING (runtime Ref{Bool}, @maybe_with_pool only)
  • Old names kept as simple const aliases for backward compatibility
  • LocalPreferences.toml key use_pooling unchanged

Tests

  • Significantly expanded USE_POOLING=false separate-process tests (290+ lines)
  • Added @maybe_with_pool :backend macro expansion tests
  • Added CUDA DisabledPool tests

Breaking changes

None — existing code using USE_POOLING and MAYBE_POOLING_ENABLED continues to work.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants