Skip to content

Code gardening apr 2026#147

Open
Roland-Park wants to merge 2 commits intoProtospace:masterfrom
Roland-Park:code-gardening-apr-2026
Open

Code gardening apr 2026#147
Roland-Park wants to merge 2 commits intoProtospace:masterfrom
Roland-Park:code-gardening-apr-2026

Conversation

@Roland-Park
Copy link
Copy Markdown

@Roland-Park Roland-Park commented Apr 19, 2026

Just fixed warnings. Did fairly minimal testing because I havent been able to get the api running locally yet, but it builds/runs and with the nature of these changes I'm thinking it's pretty safe.

change summary:

  • unused vars => yeeted them
  • img needs alt => added alt=""
  • react hook x has missing dependency - only removed empty arrays, didnt touch anything that had logic
  • Using target="_blank" without rel="noopener noreferrer" is a security risk => slapped that rel in there
  • expected === instead of ==> used === instead of ==
  • removed some comments that felt super redundant... feel free to push back on this but I default to being omega anti-comment so when I see something basically stated twice I get a bit twitchy on the delete key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant