test: explicit combo names and switch stable fast fixture#582
Open
gsprochette wants to merge 2 commits intomainfrom
Open
test: explicit combo names and switch stable fast fixture#582gsprochette wants to merge 2 commits intomainfrom
gsprochette wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an id function to the test_full_integration_combo parametrization to make the test names explicit.
Before:
flux_tiny_random-algorithms14-False-cmmdAfter:
flux_tiny_random-fora+stable_fast-False-cmmdThe stable diffusion fixture used for the stable_fast test has also been switched to a bigger one because the tiny-random model was too small for the available backends.
Related Issue
Type of Change
How Has This Been Tested?
Ran the stable-fast test which now passes, and the stable-fast combo test passes and has an explicit name.
Checklist
Additional Notes