Preserve sampled actions in float32#616
Open
Kbediako wants to merge 1 commit into
Open
Conversation
Kbediako
marked this pull request as ready for review
July 23, 2026 02:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps sampled actions in float32 through rollout storage, environment dispatch, minibatch selection, and PPO consumption.
This prevents large discrete IDs from being rounded by BF16 model precision while preserving existing reduced-precision continuous-action semantics.
Adds BF16/FP32 CUDA regression coverage for multi-head sampling, transpose/select, PPO consumption, and replayed graph slices.