Rename hamilton trough 60mL and 200mL to use correct SI casing#947
Conversation
…nd fix 120mL warning typo - Rename function and data variable to use correct SI `mL` casing - Add deprecated `hamilton_1_trough_200ml_Vb` alias (remove 2026-07) - Update existing `Hamilton_1_trough_200ml_Vb` alias to forward to new name (remove 2026-07) - Fix warning string in `hamilton_1_trough_120mL_Vb` that still said `120ml` - Update docs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| warnings.warn( | ||
| "hamilton_1_trough_200ml_Vb() is deprecated and will be removed after 2026-07. " | ||
| "Use hamilton_1_trough_200mL_Vb() instead.", |
There was a problem hiding this comment.
dates are arbitrary now that we have versions. let's say "removed in v1"
There was a problem hiding this comment.
mhmmm... this is now the development branch and since we don't have regular version releases scheduled yet people would have no idea when v1 will be - leaving them stranded, not knowing whether they would have 1 day or 4 months to update
I suggest we keep both: at least 4 month transition periods in the development branch - giving users that are dependent on the dev branch clear dates to prepare for - and specified version announcements which summarise all updates, with an emphasis on the breaking changes?
The development branch should still continue Pragmatic Programming Rule #1 "Do No Harm".
And the versioning seems still in active development with the public not knowing yet how PLR will implement it and communicate it.
2 participants
Summary
hamilton_1_trough_60ml_Vb→hamilton_1_trough_60mL_Vbhamilton_1_trough_200ml_Vb→hamilton_1_trough_200mL_Vbhamilton_1_trough_120mL_Vbwarning string that still said120mlDeprecationWarning(remove after 2026-07)Hamilton_1_trough_200ml_Vbalias to forward to new name (remove after 2026-07)Test plan
from pylabrobot.resources.hamilton.troughs import hamilton_1_trough_60mL_Vbworksfrom pylabrobot.resources.hamilton.troughs import hamilton_1_trough_200mL_VbworksDeprecationWarningand still return correctTroughpython -W all -c "from pylabrobot.resources.hamilton.troughs import hamilton_1_trough_60ml_Vb"shows warning🤖 Generated with Claude Code