Replace polynomial with piecewise linear interpolation for EnduraPlate#996
Merged
BioCam merged 4 commits intoPyLabRobot:mainfrom Apr 17, 2026
Merged
Conversation
The independently fitted 4th-degree polynomials for `Thermo_AB_96_wellplate_300ul_Vb_EnduraPlate` had round-trip errors up to 13.4 uL at 290 uL and 2.4 uL at 50 uL. Replaced both functions with `interpolate_1d` using the original calibration data. Round-trip error is now zero at all calibration points. Also corrected the error message which incorrectly referenced "ThermoScientific_96_wellplate_1200ul_Rd" (copy-paste from another plate). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thermo_AB_96_wellplate_300ul_Vb_EnduraPlatehad round-trip errors up to 13.4 uL at 290 uL and 2.4 uL at 50 uL_compute_volume_from_heightand_compute_height_from_volumewithinterpolate_1dusing the original calibration data as piecewise linear lookupThermoScientific_96_wellplate_1200ul_Rdsize_z=20.1mm is unchanged — the last calibration point (15.17 mm at 260 uL) extrapolates reasonably to the rated 300 uL capacity at ~17.2 mm, within the physical well depthCompanion to #995 (same change for MicroAmp plate).
Test plan
Well.__init__max_volume computation succeeds withbounds_handling="extrapolate"make format— passesmake lint— passes (no new errors)make typecheck— passes (no new errors)🤖 Generated with Claude Code