Merged
Conversation
ngoldbaum
approved these changes
Apr 6, 2026
Contributor
ngoldbaum
left a comment
There was a problem hiding this comment.
I'm ok with ignoring mingw-specific weirdness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I commonly develop using a mingw toolchain and noticed that for me ffi-check started failing locally after #5918 with this error:
error[E0080]: index out of bounds: the length is 1 but the index is 8 --> ...\pyo3\pyo3-ffi-check\target\x86_64-pc-windows-gnullvm\debug\build\pyo3-ffi-check-definitions-10e98362a5f4c68d\out/bindings.rs:6511:5 | 6511 | ["Alignment of __mingw_ldbl_type_t"][::std::mem::align_of::<__mingw_ldbl_type_t>() - 8usize]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ evaluation of `bindgen::_` failed here For more information about this error, try `rustc --explain E0080`. error: could not compile `pyo3-ffi-check-definitions` (lib) due to 1 previous errorI think this is just caused because bindgen generates some checks for mingw internal types, which we can simply ignore.
This will have no effect on CI (and I don't think we need to extend it as it is not commonly used), but it might be nice to fix it anyway.