Skip to content

ffi-check: ignore mingw types#5954

Merged
davidhewitt merged 1 commit intoPyO3:mainfrom
Icxolu:ffi-check/mingw
Apr 7, 2026
Merged

ffi-check: ignore mingw types#5954
davidhewitt merged 1 commit intoPyO3:mainfrom
Icxolu:ffi-check/mingw

Conversation

@Icxolu
Copy link
Copy Markdown
Member

@Icxolu Icxolu commented Apr 6, 2026

I commonly develop using a mingw toolchain and noticed that for me ffi-check started failing locally after #5918 with this error:

error[E0080]: index out of bounds: the length is 1 but the index is 8
    --> ...\pyo3\pyo3-ffi-check\target\x86_64-pc-windows-gnullvm\debug\build\pyo3-ffi-check-definitions-10e98362a5f4c68d\out/bindings.rs:6511:5
     |
6511 |     ["Alignment of __mingw_ldbl_type_t"][::std::mem::align_of::<__mingw_ldbl_type_t>() - 8usize];
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ evaluation of `bindgen::_` failed here

For more information about this error, try `rustc --explain E0080`.
error: could not compile `pyo3-ffi-check-definitions` (lib) due to 1 previous error

I think this is just caused because bindgen generates some checks for mingw internal types, which we can simply ignore.

This will have no effect on CI (and I don't think we need to extend it as it is not commonly used), but it might be nice to fix it anyway.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Apr 6, 2026
Copy link
Copy Markdown
Contributor

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with ignoring mingw-specific weirdness.

@davidhewitt davidhewitt added this pull request to the merge queue Apr 7, 2026
Merged via the queue into PyO3:main with commit cd87dcf Apr 7, 2026
47 checks passed
@Icxolu Icxolu deleted the ffi-check/mingw branch April 7, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants