Skip to content

fix: remove asynchronous model for distributed client#2149

Merged
coroa merged 1 commit into
masterfrom
fix/setup-dask
Apr 14, 2026
Merged

fix: remove asynchronous model for distributed client#2149
coroa merged 1 commit into
masterfrom
fix/setup-dask

Conversation

@coroa
Copy link
Copy Markdown
Member

@coroa coroa commented Apr 14, 2026

Changes proposed in this Pull Request

Fixup of #2137 , I took Client(asynchronous=True) from build_daily_heat_demand and build_temperature_profiles without investigating what it does.

https://distributed.dask.org/en/stable/api.html#client :

asynchronous: bool (False by default)
    Set to True if using this client within async/await functions or within Tornado 
    gen.coroutines. Otherwise this should remain False for normal use.

We and atlite are not running our own async event loop so this should always be False for us.

Checklist

Required:

  • Changes are tested locally and behave as expected.
  • Code and workflow changes are documented.
  • A release note entry is added to doc/release_notes.rst.

If applicable:

  • Changes in configuration options are reflected in scripts/lib/validation.
  • For new data sources or versions, these instructions have been followed.
  • New rules are documented in the appropriate doc/*.rst files.

Copy link
Copy Markdown
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on that :)

@coroa coroa merged commit abea573 into master Apr 14, 2026
8 of 9 checks passed
@coroa coroa deleted the fix/setup-dask branch April 14, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants