Skip to content

feat(cluster): add cluster tags for aws provider#2368

Merged
pggb25 merged 2 commits intostagingfrom
feat/cluster-tags
Feb 16, 2026
Merged

feat(cluster): add cluster tags for aws provider#2368
pggb25 merged 2 commits intostagingfrom
feat/cluster-tags

Conversation

@pggb25
Copy link
Collaborator

@pggb25 pggb25 commented Feb 10, 2026

Summary

preview here

The goal is to add a way to add tags to the cluster setting and during the cluster creation flow.
only for AWS provider. only for dev cluster for the moment (not available in prod at engine side for the moment)

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@qovery-github-app
Copy link

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview e68a6997-01bc-4a01-adcd-e763ade8d2ae test-prod-clone-pipeline-clone-test
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

@pggb25 pggb25 force-pushed the feat/cluster-tags branch 5 times, most recently from 4a9730d to 0af3166 Compare February 10, 2026 16:06
@pggb25 pggb25 changed the title feat(): cluster tags feat(cluster): add cluster tags for aws provider Feb 10, 2026
@pggb25 pggb25 marked this pull request as ready for review February 10, 2026 16:29
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 44.82759% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.28%. Comparing base (99f9214) to head (651a355).
⚠️ Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...ns/feature/src/lib/label-setting/label-setting.tsx 33.33% 3 Missing and 3 partials ⚠️
...ture/step-summary-feature/step-summary-feature.tsx 14.28% 4 Missing and 2 partials ⚠️
...page-clusters-create/step-summary/step-summary.tsx 0.00% 2 Missing and 1 partial ⚠️
...ui/page-settings-general/page-settings-general.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2368      +/-   ##
===========================================
- Coverage    47.29%   47.28%   -0.01%     
===========================================
  Files         1271     1271              
  Lines        23495    23521      +26     
  Branches      6929     6939      +10     
===========================================
+ Hits         11111    11121      +10     
- Misses       10271    10280       +9     
- Partials      2113     2120       +7     
Flag Coverage Δ
unittests 47.28% <44.82%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +41 to +43
labels_groups: ((cluster.labels_groups as unknown as Array<{ id: string }> | undefined) || []).map(
(group) => group.id
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not have to use as unknown as Array here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pggb25 pggb25 force-pushed the feat/cluster-tags branch 4 times, most recently from 2143acf to 63dd929 Compare February 16, 2026 13:47
@pggb25 pggb25 merged commit 85eecc5 into staging Feb 16, 2026
10 checks passed
@pggb25 pggb25 deleted the feat/cluster-tags branch February 16, 2026 16:47
@RemiBonnet
Copy link
Member

🎉 This PR is included in version 1.287.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants