feat(cluster): add cluster tags for aws provider#2368
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
4a9730d to
0af3166
Compare
0af3166 to
3dca138
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2368 +/- ##
===========================================
- Coverage 47.29% 47.28% -0.01%
===========================================
Files 1271 1271
Lines 23495 23521 +26
Branches 6929 6939 +10
===========================================
+ Hits 11111 11121 +10
- Misses 10271 10280 +9
- Partials 2113 2120 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...ages/cluster/src/lib/feature/page-settings-general-feature/page-settings-general-feature.tsx
Show resolved
Hide resolved
| labels_groups: ((cluster.labels_groups as unknown as Array<{ id: string }> | undefined) || []).map( | ||
| (group) => group.id | ||
| ), |
There was a problem hiding this comment.
You should not have to use as unknown as Array here
2143acf to
63dd929
Compare
63dd929 to
651a355
Compare
|
🎉 This PR is included in version 1.287.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
preview here
The goal is to add a way to add tags to the cluster setting and during the cluster creation flow.
only for AWS provider. only for dev cluster for the moment (not available in prod at engine side for the moment)
Issue:
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release