Skip to content

Make members params optional#47

Merged
martinRenou merged 1 commit intoQuantStack:masterfrom
nakul-py:opt-member
Apr 28, 2026
Merged

Make members params optional#47
martinRenou merged 1 commit intoQuantStack:masterfrom
nakul-py:opt-member

Conversation

@nakul-py
Copy link
Copy Markdown
Contributor

@nakul-py nakul-py commented Apr 28, 2026

This PR updates py2vega.Variable so that members becomes optional.

Previously, Variable required an explicit list of allowed members:

Variable("datum", ["code", "mag"])

With this change, the following is also valid:

Variable("datum")

martinRenou
martinRenou approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 2189144 into QuantStack:master Apr 28, 2026
4 checks passed
@nakul-py nakul-py deleted the opt-member branch April 28, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nakul-py @martinRenou