Fix example build and make it a slider#25
Open
martinRenou wants to merge 4 commits intomainfrom
Open
Conversation
martinRenou
changed the title
martinRenou
changed the title
AntoinePrv
reviewed
Apr 30, 2026
Member
There was a problem hiding this comment.
self.ydoc["state"] = self._state = Map()
I think pycrdt considers self.ydoc["_attrs"] to be candidate for synchronization, no?
Comment on lines
+26
to
+28
| this.state.set('min', 0); | ||
| this.state.set('max', 100); | ||
| this.state.set('value', 50); |
Member
There was a problem hiding this comment.
I think that the initial value must be derived from the Python side by doing
JS -> Py: send state_vector
Py: compute update
Py -> JS: send update
JS: apply update and subscribe to observer pattern from there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screencast.From.2026-04-30.17-17-26.mp4