Working pullback and tests for EIGH + CUDA#235
Merged
Merged
Conversation
Jutho
reviewed
May 20, 2026
| end | ||
|
|
||
| function eigh_pullback!(ΔA::AnyCuMatrix, A, DV, ΔDV, ind::AnyCuVector; kwargs...) | ||
| return eigh_pullback!(ΔA, A, DV, ΔDV, collect(ind); kwargs...) |
Member
There was a problem hiding this comment.
Just as a question; how are ind of type AnyCuVector (I assume that is then CuVector{Int}) generated? Wouldn't most index finding operations automatically yield ranges or Vector{Int} instances?
Member
Author
There was a problem hiding this comment.
In this case it's from _ind_intersect and findtruncated for these cases. My recollection (which might well be wrong) is that we wanted these inds to live on the GPU due to how the pullbacks were previously implemented.
Jutho
approved these changes
May 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#229 should be fixed. Again happy to take suggestions. I'll try to run down the
SubArraysadness inGPUArraysas this is hardly ideal