Merge pullback algorithm structs#382
Open
leburgel wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #364 and #376.
Removes the dedicated pullback algorithms for SVD, eigh and QR in favor of two general structs indicating either a pullback using a full untruncated decomposition (
FullPullback) or a pullback directly on the truncated decomposition (TruncPullback). I also updated the symbols specifying this accordingly, since here we were still using custom symbols:fulland:truncthat didn't match any struct or method name.I also updated the default behavior for QR decompositions to
MatrixAlgebraKit.DefaultAlgorithm, since the previous issue with this was resolved in the v0.16.5 release of TensorKit. I bumped the TensorKit compat accordingly.