Skip to content

Forward AD tests and cleanup for vector interface#436

Open
kshyatt wants to merge 6 commits into
mainfrom
ksh/vi
Open

Forward AD tests and cleanup for vector interface#436
kshyatt wants to merge 6 commits into
mainfrom
ksh/vi

Conversation

@kshyatt
Copy link
Copy Markdown
Member

@kshyatt kshyatt commented May 19, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Your PR no longer requires formatting changes. Thank you for your contribution!

Copy link
Copy Markdown
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Do you have any idea if this would make sense to implement at the VectorInterface level? Alternatively, to not necessarily mark everything as @is_primitive there but to already provide the implementation?

@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented May 19, 2026

We could do it there if it's generic enough? I don't have a strong opinion tbh

@lkdvos
Copy link
Copy Markdown
Member

lkdvos commented May 19, 2026

It looks like all rules are implemented solely in terms of Mooncake or VectorInterface functions, so that might just work?

@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented May 19, 2026

Nice, I can move these over tomorrow then

@kshyatt kshyatt changed the title Forward rules for vector interface Forward AD tests and cleanup for vector interface May 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ext/TensorKitMooncakeExt/tangent.jl 0.00% 8 Missing ⚠️
Files with missing lines Coverage Δ
ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl 100.00% <ø> (ø)
ext/TensorKitMooncakeExt/tangent.jl 0.00% <0.00%> (-64.50%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
Copy link
Copy Markdown
Member

lkdvos commented May 21, 2026

I think you still need the @is_primitive calls, since the VI rules are only defined for AbstractArray

@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented May 21, 2026

Addressed by another PR over there 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants