Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
lkdvos
left a comment
There was a problem hiding this comment.
Cool! Do you have any idea if this would make sense to implement at the VectorInterface level? Alternatively, to not necessarily mark everything as @is_primitive there but to already provide the implementation?
|
We could do it there if it's generic enough? I don't have a strong opinion tbh |
|
It looks like all rules are implemented solely in terms of Mooncake or VectorInterface functions, so that might just work? |
|
Nice, I can move these over tomorrow then |
Codecov Report❌ Patch coverage is
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
I think you still need the |
|
Addressed by another PR over there 😉 |
No description provided.