Draft
Conversation
add nice error messages and checks for the inner hash format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to evaluate if this is worth doing...
Scheduler: fix Lookup/Agenda consistency for deferred named tasks
When
service_taskcannot execute a named task (preimage unavailable or temporarily overweight), the task returns to the Agenda for future resolution. Previously theLookupentry was removed eagerly before the outcome was known, leaving the task unreachable by name --cancel_namedandreschedule_namedwould both fail withNotFound.This is a concrete problem for
reversible-transfers: if a transfer finalization task is deferred due to block weight pressure,cancel_transfercallscancel_namedwhich fails, and the transfer executes unhindered despite the user's cancellation attempt.Changes:
service_task: Lookup is now only removed on terminal outcomes (successful dispatch, permanently overweight). Tasks that return to the Agenda keep their Lookup and preimage reference intact.do_cancel_named: ReturnsNotFoundwhen the Lookup points to an empty or out-of-range Agenda slot, instead of silently succeeding and emitting a falseCanceledevent.