View and render stuff#129
Open
ThePlayerRolo wants to merge 9 commits intoRBLXDecomp:masterfrom
Open
Conversation
Contributor
Author
|
ready for review if you spot anything that could be changed for a higher match (or just something dumb) please lmk |
Collaborator
|
All seems good, the merge conflict needs to be resolved |
Contributor
Author
merged conflict solved (for some reason the file is said to fully replaced even though i just added the CustomMesh files) |
luasoft10
reviewed
May 6, 2026
| OmitFramePointers="true" | ||
| WholeProgramOptimization="false" | ||
| AdditionalIncludeDirectories=".\include;..\RbxViewBase;..\Rendering\RenderLib\include;..\Rendering\g3d\include;..\App\include;..\Rendering\AppDraw\include;..\boost_1_34_1\src;..\Rendering\sdl-1.2.6\include;..\RbxGraphics\include" | ||
| AdditionalIncludeDirectories="..\App\lua-5.1.1\src\;.\include;..\RbxViewBase;..\Rendering\RenderLib\include;..\Rendering\g3d\include;..\App\include;..\Rendering\AppDraw\include;..\boost_1_34_1\src;"..\Rendering\sdl-1.2.6\include";..\RbxGraphics\include" |
Collaborator
There was a problem hiding this comment.
according to obj build flags in the PDB, lua-5.1.1 was not part of the additional includes
Contributor
Author
There was a problem hiding this comment.
hm interesting, I only added it due to a build error relating to ThreadRef.h getting included (which uses lua)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, planning to work on more RBXView and RenderLib stuff