add possibility to set os and distro specific settings#16
Merged
Conversation
- mageia linux requires setting the LLVM_DEFAULT_TARGET_TRIPLE when building the amd-llvm to avoid later a build failures Signed-off-by: Mika Laitio <mika.laitio@amd.com>
Collaborator
Author
|
Tested both the therock build and pytorch 2.9 build in case where triple is not set (ubuntu) and where it set. (mageia) for gfx1201. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Linux distros like Mageia linux requires setting distro specific triple for LLVM_DEFAULT_TARGET_TRIPLE when building the amd-llvm to avoid later a build failures due to not finding all of the basic libraries that are used to build the llvm itself.