Style edits

[yugang-amd]

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[lamikr]

Thanks, your style edits looks good. There are couple of small details that were in my original text that could now be addressed as well.

1. Following restriction mentioned in one sentence does not exist anymore in the rockbuilder. There can now be multiple separate application list files. (*.apps)

Ie. this sentence can now be removed:

Currently, RockBuilder is hardcoded to use apps/core.apps to determine the application list, but in the future, this functionality could be extended to support multiple project lists.

or replaced with something like "apps/core.apps" is an example of application list configuration file that can be given as a parameter for the rockbuilder. In addition of core.apps, there are for example a following configuration files available to define a other sets of applications to build: apps/pytorch_27_amd.apps, pytorch_28_amd.apps, pytorch_29.apps, pytorch_nightly.apps, sglang.apps

2. I may have used little inconsistently the words "Project List Configuration Files" and "Application Set" to refer to same thing as I have struggled to find an short descriptive name for these *.apps files. Their purpose is to define a list of applications that together define a some type of bigger family of apps related to each others. For example pytorch version 2.7 related apps, or pytorch nightly related apps or applications required by sglang. I am open for suggestion for better wording for this term :-)

[yugang-amd]

Thanks, your style edits looks good. There are couple of small details that were in my original text that could now be addressed as well.

1. Following restriction mentioned in one sentence does not exist anymore in the rockbuilder. There can now be multiple separate application list files. (*.apps)

Ie. this sentence can now be removed:

Currently, RockBuilder is hardcoded to use apps/core.apps to determine the application list, but in the future, this functionality could be extended to support multiple project lists.

or replaced with something like "apps/core.apps" is an example of application list configuration file that can be given as a parameter for the rockbuilder. In addition of core.apps, there are for example a following configuration files available to define a other sets of applications to build: apps/pytorch_27_amd.apps, pytorch_28_amd.apps, pytorch_29.apps, pytorch_nightly.apps, sglang.apps

2. I may have used little inconsistently the words "Project List Configuration Files" and "Application Set" to refer to same thing as I have struggled to find an short descriptive name for these *.apps files. Their purpose is to define a list of applications that together define a some type of bigger family of apps related to each others. For example pytorch version 2.7 related apps, or pytorch nightly related apps or applications required by sglang. I am open for suggestion for better wording for this term :-)

Per discussion, we'll standardize .apps files as Application Set Configuration Files, and .cfg files as Application Configuration Files.

[lamikr]

Thank you very much for the cleanups, it looks now good for me.