feat: Add network field to LlamaStackDistribution#2647
Open
jgarciao wants to merge 3 commits intoRedHatQE:mainfrom
Open
feat: Add network field to LlamaStackDistribution#2647jgarciao wants to merge 3 commits intoRedHatQE:mainfrom
jgarciao wants to merge 3 commits intoRedHatQE:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdded an optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@ocp_resources/llama_stack_distribution.py`:
- Around line 3-7: There are duplicate imports of MissingRequiredArgumentError
and NamespacedResource: remove the stale line that imports both from
ocp_resources.resource (the first import) so only the correct imports remain
(NamespacedResource from ocp_resources.resource and MissingRequiredArgumentError
from ocp_resources.exceptions); if this duplication stems from the generator,
fix the generator template that emits the import block so it doesn't produce a
leftover import for MissingRequiredArgumentError.
This was referenced Feb 19, 2026
Collaborator
rnetser
requested changes
Mar 5, 2026
Collaborator
rnetser
left a comment
rnetser
left a comment
There was a problem hiding this comment.
my pr was merged; please re-generate the resouce
jgarciao
force-pushed
the
add-network-lsd
branch
from
302eeec to
e55f444
Compare
redhat-qe-bot
added
needs-rebase
and removed
changes-requested-rnetser
commented-coderabbitai[bot]
commented-jgarciao
needs-rebase
labels
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ocp_resources/llama_stack_distribution.py (1)
4-6: Fix the generator to importMissingRequiredArgumentErrorfromocp_resources.resource.This generated output drifted from the repository convention: resource classes import
MissingRequiredArgumentErrorviaocp_resources.resource, notocp_resources.exceptions. Since this file is inside the generated block, please update the class-generator template/import mapping and regenerate instead of patching this file directly.Based on learnings,
MissingRequiredArgumentErrorshould be imported fromocp_resources.resource, and generated code should be fixed in the class-generator rather than edited manually.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ocp_resources/llama_stack_distribution.py` around lines 4 - 6, The generated file imports MissingRequiredArgumentError from ocp_resources.exceptions; update the class-generator template so that generated resources import MissingRequiredArgumentError from ocp_resources.resource instead (alongside NamespacedResource), then regenerate the file rather than manually editing llama_stack_distribution.py; ensure the template's import mapping and any generator code that emits "MissingRequiredArgumentError" references ocp_resources.resource so future generated classes (e.g., the NamespacedResource-derived classes) use the correct import.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ocp_resources/llama_stack_distribution.py`:
- Around line 4-6: The generated file imports MissingRequiredArgumentError from
ocp_resources.exceptions; update the class-generator template so that generated
resources import MissingRequiredArgumentError from ocp_resources.resource
instead (alongside NamespacedResource), then regenerate the file rather than
manually editing llama_stack_distribution.py; ensure the template's import
mapping and any generator code that emits "MissingRequiredArgumentError"
references ocp_resources.resource so future generated classes (e.g., the
NamespacedResource-derived classes) use the correct import.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9490b3fe-efa6-4f6b-ba78-812cd12b4c76
⛔ Files ignored due to path filters (1)
class_generator/schema/__resources-mappings.json.gzis excluded by!**/*.gz,!class_generator/schema/**
📒 Files selected for processing (1)
ocp_resources/llama_stack_distribution.py
Author
|
New attempt after installing prek and rebasing to 11.0.120. I had to manually run prek in order to fix the linter errors |
rnetser
reviewed
Mar 18, 2026
jgarciao
force-pushed
the
add-network-lsd
branch
from
6a393c5 to
b9de204
Compare
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
jgarciao
force-pushed
the
add-network-lsd
branch
from
b9de204 to
0d663ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #2637, updating the LlamaStackDistribution resource and schema following the steps at class_generator/README.md
Summary by CodeRabbit
New Features
Documentation