Conversation
cahnge ThrottleCB return type
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
- Coverage 97.12% 97.09% -0.03%
==========================================
Files 129 129
Lines 7500 7500
==========================================
- Hits 7284 7282 -2
- Misses 216 218 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert [MOD-13853] Add throttle control callback signature for disk tiered index #908 change in
TieredHNSWDiskParamsModify
ThrottleCBtypedef to returnint.Note
Medium Risk
Header/API-level changes can break downstream compilation and any code expecting the old
ThrottleCBsignature or the removedTieredHNSWDiskParamsfields.Overview
Changes the disk-tiered throttling callback typedef
ThrottleCBto returnintinstead ofvoid, enabling callers to signal success/failure.Reverts
TieredHNSWDiskParamsto an effectively-empty struct by removing theenableThrottleCB/disableThrottleCBfunction pointers and replacing them with a placeholder field (with a note to potentially consolidate withTieredHNSWParams).Written by Cursor Bugbot for commit 4691dd1. This will update automatically on new commits. Configure here.