Skip to content

[MOD-13853] revert adding `TieredHNSWDiskParams::ThrottleCB, Modify ThrottleCB return type to int#909

Merged
meiravgri merged 1 commit intomainfrom
meiravg_throttle_params_fixed
Feb 17, 2026
Merged

[MOD-13853] revert adding `TieredHNSWDiskParams::ThrottleCB, Modify ThrottleCB return type to int#909
meiravgri merged 1 commit intomainfrom
meiravg_throttle_params_fixed

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Feb 17, 2026


Note

Medium Risk
Header/API-level changes can break downstream compilation and any code expecting the old ThrottleCB signature or the removed TieredHNSWDiskParams fields.

Overview
Changes the disk-tiered throttling callback typedef ThrottleCB to return int instead of void, enabling callers to signal success/failure.

Reverts TieredHNSWDiskParams to an effectively-empty struct by removing the enableThrottleCB/disableThrottleCB function pointers and replacing them with a placeholder field (with a note to potentially consolidate with TieredHNSWParams).

Written by Cursor Bugbot for commit 4691dd1. This will update automatically on new commits. Configure here.

cahnge ThrottleCB return type
@meiravgri meiravgri changed the title revert TieredHNSWDiskParams [MOD-13853] revert adding `TieredHNSWDiskParams::ThrottleCB, Modify ThrottleCB return type to int Feb 17, 2026
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.09%. Comparing base (69bbc39) to head (4691dd1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   97.12%   97.09%   -0.03%     
==========================================
  Files         129      129              
  Lines        7500     7500              
==========================================
- Hits         7284     7282       -2     
- Misses        216      218       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue Feb 17, 2026
Merged via the queue into main with commit 8819850 Feb 17, 2026
17 checks passed
@meiravgri meiravgri deleted the meiravg_throttle_params_fixed branch February 17, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants