Skip to content

SRC: use LSAME for TRANS checks in gttrs#1239

Merged
langou merged 1 commit intoReference-LAPACK:masterfrom
nakatamaho:cleanup/gttrs-lsame-trans
May 3, 2026
Merged

SRC: use LSAME for TRANS checks in gttrs#1239
langou merged 1 commit intoReference-LAPACK:masterfrom
nakatamaho:cleanup/gttrs-lsame-trans

Conversation

@nakatamaho
Copy link
Copy Markdown
Contributor

This PR replaces direct case-sensitive TRANS character comparisons in the GTTRS routines with LSAME.

Files updated:

SRC/sgttrs.f
SRC/dgttrs.f
SRC/cgttrs.f
SRC/zgttrs.f

Summary:

  • Replace direct N/n, T/t, and C/c TRANS checks with LSAME.
  • Use LSAME( TRANS, 'T' ) for the complex ITRANS branch.
  • Add LSAME as a logical external function.

Validation:

  • Compiled sgttrs.f, dgttrs.f, cgttrs.f, and zgttrs.f with gfortran -O2 -c.
  • Ran git diff --check for the staged changes before commit.

Replace direct case-sensitive TRANS character comparisons in the GTTRS routines with LSAME. This keeps option handling consistent with the surrounding LAPACK convention for case-insensitive checks.
langou
langou previously approved these changes May 3, 2026
@nakatamaho nakatamaho dismissed langou’s stale review May 3, 2026 11:20

The merge-base changed after approval.

langou
langou previously approved these changes May 3, 2026
@langou langou closed this May 3, 2026
@langou langou reopened this May 3, 2026
@langou langou dismissed their stale review May 3, 2026 11:20

The merge-base changed after approval.

@langou langou merged commit 71bf5ec into Reference-LAPACK:master May 3, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants