Skip to content

SRC: use LSAME for UPLO checks in lalsd#1240

Merged
langou merged 1 commit intoReference-LAPACK:masterfrom
nakatamaho:cleanup/lalsd-lsame-uplo
May 3, 2026
Merged

SRC: use LSAME for UPLO checks in lalsd#1240
langou merged 1 commit intoReference-LAPACK:masterfrom
nakatamaho:cleanup/lalsd-lsame-uplo

Conversation

@nakatamaho
Copy link
Copy Markdown
Contributor

This PR replaces direct UPLO character comparisons in the LALSD routines with LSAME.

Files updated:

SRC/slalsd.f
SRC/dlalsd.f
SRC/clalsd.f
SRC/zlalsd.f

Summary:

  • Replace UPLO.EQ.'L' with LSAME( UPLO, 'L' ).
  • Add LSAME as a logical external function.

Validation:

  • Ran git diff --check for the staged changes before commit.
  • Confirmed full build and full TESTING pass.

Replace direct UPLO character comparisons in the LALSD routines with LSAME. This keeps option handling consistent with the surrounding LAPACK convention for case-insensitive checks.
langou
langou previously approved these changes May 3, 2026
@nakatamaho nakatamaho dismissed langou’s stale review May 3, 2026 11:44

The merge-base changed after approval.

@langou langou closed this May 3, 2026
@langou langou reopened this May 3, 2026
langou
langou previously approved these changes May 3, 2026
@nakatamaho nakatamaho dismissed langou’s stale review May 3, 2026 12:25

The merge-base changed after approval.

langou
langou previously approved these changes May 3, 2026
@nakatamaho nakatamaho dismissed langou’s stale review May 3, 2026 12:47

The merge-base changed after approval.

@langou langou closed this May 3, 2026
@langou langou reopened this May 3, 2026
@langou langou merged commit 8cd9026 into Reference-LAPACK:master May 3, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants