[Feat] Notification sent with Login to Github button when not authenticated#80
Open
Prince-Mendiratta wants to merge 7 commits intoRocketChat:mainfrom
Open
[Feat] Notification sent with Login to Github button when not authenticated#80Prince-Mendiratta wants to merge 7 commits intoRocketChat:mainfrom
Login to Github button when not authenticated#80Prince-Mendiratta wants to merge 7 commits intoRocketChat:mainfrom
Conversation
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
1 task
Contributor
Author
|
gentle bump @samad-yar-khan |
Contributor
|
This reverts commit 9e74841.
Contributor
Author
|
Reverted changes for |
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
$ Fixes #47
Check for the following commands if the notification displayed has the "Github Login" button along with the message prompt to login.
/github me/github subscribe/github Username/RepositoryName subscribe/github Username/RepositoryName unsubscribe/github issue/github issues/github searchProposed changes (including videos or screenshots)
Firstly, to keep code DRY and avoid repetition of code, I've created a separate method to create the
LoginActionBlock. This method is reused in all places to create the action block. All the required commands will now directly show theLogin to Githubbutton, avoiding extra steps to authenticate.Second important change is that in the
Assign and Share Issues -> /github issuescommand, it will not work without authorization first. I added this because this was mentioned in the expected results by @Nabhag8848 in the linked issue.Results
https://drive.google.com/file/d/1Cqe1dwObEMZ9fv0X_69O-a27icAhEjVR/view?usp=sharing
cc @samad-yar-khan @Nabhag8848