Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented May 9, 2025

https://rocketchat.atlassian.net/browse/ARCH-1460

https://rocketchat.atlassian.net/browse/ARCH-1603

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: 6529acd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 9, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@ggazzo ggazzo added this to the 8.0.0 milestone May 9, 2025
@ggazzo ggazzo force-pushed the break/remove-streamhub branch 2 times, most recently from c981920 to d5954c9 Compare May 9, 2025 21:30
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35964/

Built to branch gh-pages at 2025-05-14 18:07 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 19.60784% with 164 lines in your changes missing coverage. Please review.

Project coverage is 64.63%. Comparing base (4e37cdd) to head (6529acd).
Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #35964      +/-   ##
=================================================
- Coverage          64.63%   64.63%   -0.01%     
=================================================
  Files               3244     3244              
  Lines              95341    95363      +22     
  Branches           17849    17879      +30     
=================================================
+ Hits               61627    61641      +14     
- Misses             30821    30826       +5     
- Partials            2893     2896       +3     
Flag Coverage Δ
e2e 58.12% <ø> (-0.08%) ⬇️
unit 71.93% <19.60%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo force-pushed the break/remove-streamhub branch 3 times, most recently from 73826bd to 3da1402 Compare May 11, 2025 02:34
@ggazzo ggazzo marked this pull request as ready for review May 13, 2025 20:36
@ggazzo ggazzo requested review from a team as code owners May 13, 2025 20:36
@ggazzo ggazzo force-pushed the break/remove-streamhub branch from 3da1402 to ceeeee8 Compare May 14, 2025 17:53
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label May 14, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 14, 2025
@ggazzo ggazzo force-pushed the break/remove-streamhub branch from 6a537c5 to 6529acd Compare May 14, 2025 19:17
@ggazzo ggazzo merged commit b6a7802 into release-8.0.0 May 14, 2025
38 checks passed
@ggazzo ggazzo deleted the break/remove-streamhub branch May 14, 2025 20:39
ggazzo added a commit that referenced this pull request May 14, 2025
ggazzo added a commit that referenced this pull request May 14, 2025
ggazzo added a commit that referenced this pull request Jun 4, 2025
ggazzo added a commit that referenced this pull request Jun 5, 2025
ggazzo added a commit that referenced this pull request Jun 25, 2025
ggazzo added a commit that referenced this pull request Jul 4, 2025
ggazzo added a commit that referenced this pull request Jul 9, 2025
ggazzo added a commit that referenced this pull request Jul 29, 2025
ggazzo added a commit that referenced this pull request Aug 6, 2025
ggazzo added a commit that referenced this pull request Aug 6, 2025
ggazzo added a commit that referenced this pull request Aug 6, 2025
ggazzo added a commit that referenced this pull request Aug 6, 2025
ggazzo added a commit that referenced this pull request Aug 18, 2025
ggazzo added a commit that referenced this pull request Aug 19, 2025
ggazzo added a commit that referenced this pull request Aug 27, 2025
ggazzo added a commit that referenced this pull request Sep 4, 2025
ggazzo added a commit that referenced this pull request Sep 30, 2025
ggazzo added a commit that referenced this pull request Oct 3, 2025
ggazzo added a commit that referenced this pull request Oct 31, 2025
ggazzo added a commit that referenced this pull request Oct 31, 2025
yash-rajpal pushed a commit that referenced this pull request Nov 4, 2025
ggazzo added a commit that referenced this pull request Nov 4, 2025
ggazzo added a commit that referenced this pull request Nov 5, 2025
ggazzo added a commit that referenced this pull request Nov 5, 2025
ggazzo added a commit that referenced this pull request Nov 5, 2025
ggazzo added a commit that referenced this pull request Nov 6, 2025
ggazzo added a commit that referenced this pull request Nov 12, 2025
ggazzo added a commit that referenced this pull request Nov 12, 2025
ggazzo added a commit that referenced this pull request Nov 13, 2025
ggazzo added a commit that referenced this pull request Nov 18, 2025
ggazzo added a commit that referenced this pull request Dec 2, 2025
ggazzo added a commit that referenced this pull request Dec 9, 2025
ggazzo added a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants