-
Notifications
You must be signed in to change notification settings - Fork 12.6k
fix: update useAppSlashCommands tests to match mutation-based implementation #37667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update useAppSlashCommands tests to match mutation-based implementation #37667
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: d-gubert <[email protected]>
|
@copilot unit test is still failing, fix the tests |
Co-authored-by: d-gubert <[email protected]>
Co-authored-by: d-gubert <[email protected]>
Co-authored-by: d-gubert <[email protected]>
Fixed in commits 50c4a3a, d281b9a, and 6f3dcfc. The tests were failing because they expected commands to be removed immediately after events, but the mutation lifecycle works differently:
Updated tests to:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/faulty-slashcommand-mutation #37667 +/- ##
===================================================================
Coverage ? 68.82%
===================================================================
Files ? 3361
Lines ? 114241
Branches ? 20611
===================================================================
Hits ? 78631
Misses ? 33517
Partials ? 2093
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
3e82dd8
into
fix/faulty-slashcommand-mutation
…ntation (#37667) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: d-gubert <[email protected]>
invalidateQueriescalls✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.