Skip to content

Conversation

Copy link

Copilot AI commented Dec 2, 2025

  • Understand the implementation changes (query to mutation)
  • Fix test assertions to match the new mutation-based implementation
  • Remove expectations for invalidateQueries calls
  • Ensure all tests properly verify mutation behavior
  • Fix tests to mock API responses for removed/disabled commands
  • Wait for mutation to complete before asserting final state
  • Improve test maintainability and safety using filter
  • Code review and final verification

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 2, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2025

⚠️ No Changeset found

Latest commit: 6f3dcfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2025

CLA assistant check
All committers have signed the CLA.

Copilot AI changed the title [WIP] Fix slashcommand query to mutation fix: update useAppSlashCommands tests to match mutation-based implementation Dec 2, 2025
Copilot AI requested a review from d-gubert December 2, 2025 01:15
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 359MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB -793B
queue-worker-service 132MiB 132MiB +182B
ddp-streamer-service 127MiB 127MiB -123B
account-service 114MiB 114MiB -5B
stream-hub-service 111MiB 111MiB +236B
authorization-service 111MiB 111MiB -320B
presence-service 111MiB 111MiB -861B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 13:55", "12/02 15:09 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 11 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37667
  • Baseline: develop
  • Timestamp: 2025-12-02 15:09:44 UTC
  • Historical data points: 11

Updated: Tue, 02 Dec 2025 15:09:44 GMT

@d-gubert
Copy link
Member

d-gubert commented Dec 2, 2025

@copilot unit test is still failing, fix the tests

Copy link
Author

Copilot AI commented Dec 2, 2025

@copilot unit test is still failing, fix the tests

Fixed in commits 50c4a3a, d281b9a, and 6f3dcfc. The tests were failing because they expected commands to be removed immediately after events, but the mutation lifecycle works differently:

  1. onMutate clears all commands
  2. API fetches updated list
  3. onSettled adds back the fetched commands

Updated tests to:

  • Mock API responses to return the correct command list after removal/disable events
  • Wait for mutation to complete before asserting final state
  • Use filter instead of array indexing for safer, more maintainable code

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (fix/faulty-slashcommand-mutation@6ae52a5). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                         @@
##             fix/faulty-slashcommand-mutation   #37667   +/-   ##
===================================================================
  Coverage                                    ?   68.82%           
===================================================================
  Files                                       ?     3361           
  Lines                                       ?   114241           
  Branches                                    ?    20611           
===================================================================
  Hits                                        ?    78631           
  Misses                                      ?    33517           
  Partials                                    ?     2093           
Flag Coverage Δ
e2e 57.30% <ø> (?)
e2e-api 43.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert marked this pull request as ready for review December 2, 2025 17:38
@d-gubert d-gubert requested a review from a team as a code owner December 2, 2025 17:38
@d-gubert d-gubert merged commit 3e82dd8 into fix/faulty-slashcommand-mutation Dec 2, 2025
60 of 75 checks passed
@d-gubert d-gubert deleted the copilot/sub-pr-37666 branch December 2, 2025 17:38
d-gubert added a commit that referenced this pull request Dec 4, 2025
…ntation (#37667)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: d-gubert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants