Skip to content

Conversation

@lucas-a-pelegrino
Copy link
Member

@lucas-a-pelegrino lucas-a-pelegrino commented Dec 3, 2025

Proposed changes (including videos or screenshots)

This PR adds a changeset for PR #37168

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • New Features

    • Added a new endpoint for removing monitors in livechat operations.
  • Deprecation

    • The previous livechat:removeMonitor endpoint is deprecated; migrate to the new monitor removal endpoint.
  • Chores

    • Recorded patch-level package updates and a minor client-side logging change.

✏️ Tip: You can customize this high-level summary in your review settings.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 3, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025

🦋 Changeset detected

Latest commit: e8b5bfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/http-router Patch
@rocket.chat/models Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/livechat Patch
@rocket.chat/mock-providers Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/media-calls Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/core-typings Patch
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025

Walkthrough

Adds a changeset documenting patch bumps for two packages and deprecates livechat:removeMonitor in favor of a new livechat/monitor.remove endpoint; also adds a stray console.log('test') in a client ChatInfo component.

Changes

Cohort / File(s) Summary
Changeset Configuration
\.changeset/brown-carrots-bathe\.md
Documents patch version updates for @rocket.chat/meteor and @rocket.chat/rest-typings; marks livechat:removeMonitor deprecated and introduces livechat/monitor.remove as replacement.
Client UI change
apps/meteor/client/views/omnichannel/directory/chats/ChatInfo/ChatInfo.tsx
Adds console.log('test') after fetching room data via useOmnichannelRoomInfo(id), introducing a render-path side effect (console output).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Small, heterogeneous changes: one documentation/changeset update and one minor client-side console side effect.
  • Areas to check:
    • ChatInfo.tsx — confirm removal of the debugging console.log or justify its presence; ensure no performance or leaking-sensitive-data concerns.
    • .changeset/... — ensure deprecation text and replacement endpoint naming are correct and consistent with API docs.

Possibly related PRs

Suggested reviewers

  • KevLehman
  • aleksandernsilva
  • tassoevan

Poem

🐰 I hopped through code with a twitch of my nose,
A monitor retired where the wild wind blows.
A new route steps in with a bright little drum,
I logged a small "test" — then scurried off, thump-thump! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The addition of console.log('test') in ChatInfo.tsx appears to be a debugging statement unrelated to the changeset's stated objective of documenting the deprecation. Remove the console.log('test') statement from ChatInfo.tsx as it is a debugging artifact unrelated to the changeset documentation and deprecation notice.
Title check ❓ Inconclusive The title 'chore: Missing changeset' is vague and generic, using non-descriptive terms that don't convey meaningful information about the changeset content. Consider a more descriptive title that reflects the actual changes, such as 'chore: Add changeset for livechat monitor removal deprecation' to better communicate the changeset purpose.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The changeset documents a deprecation for livechat:removeMonitor and introduces a new endpoint livechat/monitor.remove, which aligns with the linked issue CORE-1415.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/CORE-1415-changeset

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e3fb635 and 7bccfb9.

📒 Files selected for processing (1)
  • apps/meteor/client/views/omnichannel/directory/chats/ChatInfo/ChatInfo.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/meteor/client/views/omnichannel/directory/chats/ChatInfo/ChatInfo.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.14.0 milestone Dec 3, 2025
@lucas-a-pelegrino lucas-a-pelegrino added the stat: QA assured Means it has been tested and approved by a company insider label Dec 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 3, 2025
dougfabris
dougfabris previously approved these changes Dec 3, 2025
@dougfabris dougfabris marked this pull request as ready for review December 3, 2025 20:22
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/brown-carrots-bathe.md (1)

6-6: Clarify the deprecation/replacement scope in the changeset description.

The description mentions deprecation of livechat:removeMonitor and introduction of livechat/monitor.remove, but it does not clarify:

  • Whether this is a breaking change for REST API consumers or internal only
  • Whether the old endpoint remains functional or is removed entirely
  • Whether both packages require updates to support this change, or if this represents independent patch updates

Consider expanding the description to explicitly state the nature of the change (e.g., "Deprecates REST endpoint livechat:removeMonitor in favor of livechat/monitor.remove with backward compatibility maintained").

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dc51116 and e3fb635.

📒 Files selected for processing (1)
  • .changeset/brown-carrots-bathe.md (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
Learnt from: sampaiodiego
Repo: RocketChat/Rocket.Chat PR: 37357
File: apps/meteor/ee/server/startup/federation.ts:39-74
Timestamp: 2025-11-05T20:53:57.761Z
Learning: In Rocket.Chat (apps/meteor/app/settings/server/CachedSettings.ts), the settings.watchMultiple() method immediately invokes its callback with current values if all requested settings exist in the store, then continues watching for subsequent changes. It does not wait for a setting to change before the first invocation.
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

  • .changeset/brown-carrots-bathe.md

@dougfabris dougfabris removed this from the 7.14.0 milestone Dec 3, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 3, 2025
@dougfabris dougfabris added this to the 7.14.0 milestone Dec 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 3, 2025
@dougfabris dougfabris closed this Dec 4, 2025
@dougfabris dougfabris reopened this Dec 4, 2025
@dougfabris dougfabris requested a review from a team as a code owner December 4, 2025 12:59
@dougfabris dougfabris force-pushed the chore/CORE-1415-changeset branch from 7bccfb9 to b624b5b Compare December 4, 2025 13:09
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 359MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB +721B
queue-worker-service 132MiB 132MiB +65B
ddp-streamer-service 126MiB 126MiB +1.6KiB
account-service 113MiB 113MiB +109B
stream-hub-service 111MiB 111MiB +1.2KiB
authorization-service 111MiB 111MiB -358B
presence-service 111MiB 111MiB +325B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 13:27 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 12 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37688
  • Baseline: develop
  • Timestamp: 2025-12-04 13:27:00 UTC
  • Historical data points: 12

Updated: Thu, 04 Dec 2025 13:27:00 GMT

@dougfabris dougfabris requested a review from ggazzo December 4, 2025 14:05
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 5, 2025
@ggazzo ggazzo merged commit b802430 into develop Dec 8, 2025
8 checks passed
@ggazzo ggazzo deleted the chore/CORE-1415-changeset branch December 8, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants