Skip to content

Conversation

Copy link

Copilot AI commented Dec 4, 2025

Proposed changes (including videos or screenshots)

Migrates 37 apps-engine test files from Alsatian to Node.js built-in test framework (node:test and node:assert). Each file converted in a separate commit for easier review.

Conversion patterns:

  • describe() replaces class-based test fixtures
  • it() replaces @Test and @AsyncTest decorators
  • beforeEach()/afterEach() replace @SetupFixture/@Teardown
  • assert.strictEqual() replaces Expect().toBe()
  • assert.deepStrictEqual() replaces Expect().toEqual()
  • assert.throws()/assert.rejects() replace Expect().toThrowError()
  • mock.method() replaces SpyOn()

Converted files by category:

  • Error tests (7): All error class tests
  • Compiler tests (3): AppCompiler, AppImplements, AppFabricationFulfillment
  • Logging tests (1): AppConsole
  • Manager tests (5): AppApi, AppVideoConfProvider, AppOutboundCommunicationProvider, AppSlashCommand, AppAccessorManager
  • Accessor tests (15): ConfigurationModify, EnvironmentRead, EnvironmentWrite, EnvironmentalVariableRead, MessageExtender, Modify, Notifier, PersistenceRead, RoomExtender, ServerSettingRead, ServerSettingsModify, SettingRead, SettingsExtend, SlashCommandsExtend, SlashCommandsModify, VideoConfProviderExtend, VideoConferenceRead
  • Runtime tests (2): DenoRuntimeSubprocessController, LivenessManager
  • Misc tests (1): Utilities
  • Core tests (3): AppManager

All converted tests maintain identical test coverage and assertions. Files placed in packages/apps-engine/tests/node-tests/server/ mirroring original structure.

Remaining: 27 test files (18 accessor, 9 manager) - larger, more complex tests requiring careful conversion.

Issue(s)

Steps to test or reproduce

Further comments


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 4, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2025

⚠️ No Changeset found

Latest commit: 36f20f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 8 commits December 4, 2025 10:59
Convert all 7 error test files from Alsatian to NodeJS built-in test framework:
- CommandAlreadyExistsError
- CommandHasAlreadyBeenTouchedError
- CompilerError
- MustContainFunctionError
- MustExtendAppError
- NotEnoughMethodArgumentsError
- RequiredApiVersionError

Co-authored-by: d-gubert <[email protected]>
Convert all 3 compiler test files:
- AppCompiler
- AppImplements
- AppFabricationFulfillment

Co-authored-by: d-gubert <[email protected]>
Convert 4 simple manager test files:
- AppVideoConfProvider
- AppOutboundCommunicationProvider
- AppApi
- AppSlashCommand

Co-authored-by: d-gubert <[email protected]>
Convert 5 basic accessor test files:
- EnvironmentWrite
- EnvironmentRead
- PersistenceRead
- EnvironmentalVariableRead
- VideoConferenceRead

Co-authored-by: d-gubert <[email protected]>
Convert 6 accessor test files:
- Notifier
- MessageExtender
- VideoConfProviderExtend
- SettingRead
- RoomExtender
- ServerSettingRead

Co-authored-by: d-gubert <[email protected]>
Convert 4 accessor test files:
- SlashCommandsExtend
- SlashCommandsModify
- Modify
- SettingsExtend

Co-authored-by: d-gubert <[email protected]>
Copilot AI changed the title [WIP] Start test conversion from Alsatian to NodeJS chore: convert apps-engine tests from Alsatian to Node.js built-in test framework Dec 4, 2025
Copilot AI requested a review from d-gubert December 4, 2025 11:13
Copilot finished work on behalf of d-gubert December 4, 2025 11:13
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 359MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB +900B
queue-worker-service 132MiB 132MiB +185B
ddp-streamer-service 126MiB 126MiB +330B
account-service 113MiB 113MiB +607B
stream-hub-service 111MiB 111MiB +1.1KiB
authorization-service 111MiB 111MiB -893B
presence-service 111MiB 111MiB +978B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 11:46 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 12 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37694
  • Baseline: develop
  • Timestamp: 2025-12-04 11:46:39 UTC
  • Historical data points: 12

Updated: Thu, 04 Dec 2025 11:46:39 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants