-
Notifications
You must be signed in to change notification settings - Fork 12.6k
chore: convert apps-engine tests from Alsatian to Node.js built-in test framework #37694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chore/apps-engine-tests-conversion-start
Are you sure you want to change the base?
chore: convert apps-engine tests from Alsatian to Node.js built-in test framework #37694
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Convert all 7 error test files from Alsatian to NodeJS built-in test framework: - CommandAlreadyExistsError - CommandHasAlreadyBeenTouchedError - CompilerError - MustContainFunctionError - MustExtendAppError - NotEnoughMethodArgumentsError - RequiredApiVersionError Co-authored-by: d-gubert <[email protected]>
Co-authored-by: d-gubert <[email protected]>
Convert all 3 compiler test files: - AppCompiler - AppImplements - AppFabricationFulfillment Co-authored-by: d-gubert <[email protected]>
Convert 4 simple manager test files: - AppVideoConfProvider - AppOutboundCommunicationProvider - AppApi - AppSlashCommand Co-authored-by: d-gubert <[email protected]>
Convert 5 basic accessor test files: - EnvironmentWrite - EnvironmentRead - PersistenceRead - EnvironmentalVariableRead - VideoConferenceRead Co-authored-by: d-gubert <[email protected]>
Convert 6 accessor test files: - Notifier - MessageExtender - VideoConfProviderExtend - SettingRead - RoomExtender - ServerSettingRead Co-authored-by: d-gubert <[email protected]>
Convert 4 accessor test files: - SlashCommandsExtend - SlashCommandsModify - Modify - SettingsExtend Co-authored-by: d-gubert <[email protected]>
Co-authored-by: d-gubert <[email protected]>
Proposed changes (including videos or screenshots)
Migrates 37 apps-engine test files from Alsatian to Node.js built-in test framework (
node:testandnode:assert). Each file converted in a separate commit for easier review.Conversion patterns:
describe()replaces class-based test fixturesit()replaces@Testand@AsyncTestdecoratorsbeforeEach()/afterEach()replace@SetupFixture/@Teardownassert.strictEqual()replacesExpect().toBe()assert.deepStrictEqual()replacesExpect().toEqual()assert.throws()/assert.rejects()replaceExpect().toThrowError()mock.method()replacesSpyOn()Converted files by category:
All converted tests maintain identical test coverage and assertions. Files placed in
packages/apps-engine/tests/node-tests/server/mirroring original structure.Remaining: 27 test files (18 accessor, 9 manager) - larger, more complex tests requiring careful conversion.
Issue(s)
Steps to test or reproduce
Further comments
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.