[Improve] Guard Discord Fast retry recovery - #2062
Draft
roomote-community[bot] wants to merge 1 commit into
Draft
Conversation
Contributor
Author
| async ({ | ||
| adapter, | ||
| }: { | ||
| adapter: { requestDurableRetry: (at: Date) => Promise<void> }; |
Contributor
Author
There was a problem hiding this comment.
This mock only exposes and invokes requestDurableRetry; the immediate recovery callback is a separate adapter contract (requestDurableResume in fast-agent.ts). Calling turnLock.durableResume exercises shutdown recovery instead, so removing or miswiring the adapter's immediate wakeup would still pass this regression test. Add requestDurableResume to the mock adapter and assert it wakes wakeParentEventNow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a Discord Fast-handler regression test that verifies accepted turns are durably persisted, carry their lock signal and durable admission into inference, and expose both scheduled and immediate queue wakeups for retry recovery.
Why this change was made
Fast retry recovery is implemented in the shared service, but the Discord adapter boundary did not prove that it supplies the durable state and wake callbacks that make provider retries and restart recovery work. This closes that coverage gap around the post-1.0 recovery path.
Impact
There is no production behavior change. The test prevents Discord Fast requests from silently losing durable retry and restart-recovery wiring in future refactors.