[Fix] Slack working indicator disappears when an earlier turn receives its title - #2270
Merged
roomote-roomote[bot] merged 1 commit intoSep 6, 2026
Merged
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 5, 2026 20:14
8 tasks
daniel-lxs
approved these changes
Sep 6, 2026
roomote-roomote
Bot
deleted the
fix/slack-late-title-status-2b5crtokhf5ks
branch
September 6, 2026 14:40
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No issue opened. This is a scoped internal reliability fix.
Why this PR exists
A completed short Fast turn could receive its generated title after the next turn started. That callback set the shared Slack session to active, clearing the newer turn's working indicator.
What changed
Initialize the idle Slack session during short-turn settlement, even when its title is not ready. Later title callbacks only rename the session and never write its status. This preserves delayed titles without a process-local ownership registry.
Extend the existing mock Slack server to retain agent session status and title so the actual notifier/WebClient HTTP path can be checked through
/mock/state.Impact: late titles no longer clear newer processing status. Untitled short turns now incur one extra Slack request during settlement; the 300 ms processing delay remains unchanged. Broader lock-loss cleanup and retry-indicator behavior are not changed.
How it was tested
Classification: draft awaiting proof. Focused automated and HTTP-adapter evidence passes; live end-to-end Slack orchestration/rendering remains unverified.
fast-agent-session-activity.test.ts,fast-agent-session-activity.integration.test.ts,agent-session-title-sync.test.ts,mock-slack-server.test.ts, andslack-notifier.test.tsusingpnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/slack exec vitest runwith those paths.pnpm --filter @roomote/slack check-types, changed-file oxfmt, andgit diff --checkpassed.Before promoting readiness, replay two successive Fast turns through the full inbound Slack path with a delayed first title and verify native working status plus title persistence. This is not a claim that Slack indicators cover background coding or retry waits.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetThe full formatting-inclusive lint and tsc monorepo commands were not run; the pre-push fast gates and package tsc passed. No changeset was added.