Add wrapper class for automatic node cloning #4350
Open
+257
−555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This patch adds a wrapper class called Cloneable, which can be used to automatically perform polymorphic copying. This should greatly reduce the need for error-prone user defined copy constructors and assignment operators. As a demonstration/first step, this patch also uses Cloneable to simplify the pattern nodes described in gcc/rust/ast/rust-pattern.h. gcc/rust/ChangeLog: * ast/rust-ast.h: Include "rust-cloneable.h". (struct CloneableDelegate<std::unique_ptr<AST::Pattern>>): Add specialization. * ast/rust-pattern.cc (IdentifierPattern::as_string): Handle field type changes. (RangePattern::as_string): Likewise. (ReferencePattern::as_string): Likewise. (StructPatternFieldTuplePat::as_string): Likewise. (StructPatternFieldIdentPat::as_string): Likewise. (StructPatternElements::as_string): Likewise. (TupleStructItemsNoRest::as_string): Likewise. (TupleStructItemsHasRest::as_string): Likewise. (TupleStructPattern::as_string): Likewise. (TuplePatternItemsNoRest::as_string): Likewise. (TuplePatternItemsHasRest::as_string): Likewise. (TuplePattern::as_string): Likewise. (SlicePatternItemsNoRest::as_string): Likewise. (SlicePatternItemsHasRest::as_string): Likewise. (SlicePattern::as_string): Likewise. (AltPattern::as_string): Likewise. * ast/rust-pattern.h: Include "rust-cloneable.h". (class IdentifierPattern): Use Cloneable to simplify copying. (class RangePattern): Likewise. (class ReferencePattern): Likewise. (class StructPatternFieldTuplePat): Likewise. (class StructPatternFieldIdentPat): Likewise. (class StructPatternElements): Likewise. (class TupleStructItemsNoRest): Likewise. (class TupleStructItemsHasRest): Likewise. (class TupleStructPattern): Likewise. (class TuplePatternItemsNoRest): Likewise. (class TuplePatternItemsHasRest): Likewise. (class TuplePattern): Likewise. (class GroupedPattern): Likewise. (class SlicePatternItemsNoRest): Likewise. (class SlicePatternItemsHasRest): Likewise. (class SlicePattern): Likewise. (class AltPattern): Likewise. (struct CloneableDelegate<std::unique_ptr<AST::RangePatternBound>>): Add specialization. (struct CloneableDelegate<std::unique_ptr<AST::TupleStructItems>>): Likewise. (struct CloneableDelegate<std::unique_ptr<AST::TuplePatternItems>>): Likewise. (struct CloneableDelegate<std::unique_ptr<AST::SlicePatternItems>>): Likewise. (struct CloneableDelegate<std::unique_ptr<AST::StructPatternField>>): Likewise. * util/rust-cloneable.h: New file. Signed-off-by: Owen Avery <[email protected]>
Member
|
I haven't really looked at the PR yet @powerboat9, does it tie in with something like #3799? |
Collaborator
Author
|
Not really, though it would be compatible. However, on a side note, #4323 does tie in/replace the reconstruct mechanism. This PR should provide a way to remove virtually all user defined copy constructors/assignment operators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a wrapper class called
Cloneable, which can be used to automatically perform polymorphic copying. This should greatly reduce the need for error-prone user defined copy constructors and assignment operators.As a demonstration/first step, this patch also uses Cloneable to simplify the pattern nodes described in
ast/rust-pattern.h.